From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46755 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OhKr4-0002cl-Jk
	for qemu-devel@nongnu.org; Fri, 06 Aug 2010 07:12:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1OhKr3-0003Fy-6x
	for qemu-devel@nongnu.org; Fri, 06 Aug 2010 07:12:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20260)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1OhKr2-0003Fd-W7
	for qemu-devel@nongnu.org; Fri, 06 Aug 2010 07:12:49 -0400
Date: Fri, 6 Aug 2010 12:12:45 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] rtc: Remove TARGET_I386 from
	qemu-config.c, enables driftfix
Message-ID: <20100806111245.GA23061@redhat.com>
References: <a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a2c3ccd27f9a2deda17604a82384ba6c2a8e354e.1277304233.git.amit.shah@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, qemu list <qemu-devel@nongnu.org>, Gleb Natapov <gleb@redhat.com>, Juan Quintela <quintela@redhat.com>

On Wed, Jun 23, 2010 at 08:14:04PM +0530, Amit Shah wrote:
> qemu-config.c doesn't contain any target-specific code, and the
> TARGET_I386 conditional code didn't get compiled as a result. Removing
> this enables the driftfix parameter for rtc.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
>  qemu-config.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-config.c b/qemu-config.c
> index 95abe61..730ffd9 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -247,11 +247,9 @@ QemuOptsList qemu_rtc_opts = {
>          },{
>              .name = "clock",
>              .type = QEMU_OPT_STRING,
> -#ifdef TARGET_I386
>          },{
>              .name = "driftfix",
>              .type = QEMU_OPT_STRING,
> -#endif
>          },
>          { /* end if list */ }
>      },


Is there any reason this patch hasn't been applied to GIT yet ? I'm told 
that using this option is critical to making certain guests work reliably
so we want to use it from libvirt/virt-manager for the OS in question.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|