From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52637 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oj8Kn-00028y-Dp
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 06:15:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Oj8Kl-0007Fb-Ph
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 06:14:57 -0400
Received: from mtagate2.uk.ibm.com ([194.196.100.162]:50443)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Oj8Kl-0007BD-Ip
	for qemu-devel@nongnu.org; Wed, 11 Aug 2010 06:14:55 -0400
Received: from d06nrmr1806.portsmouth.uk.ibm.com
	(d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193])
	by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o7BAEZrJ003913
	for <qemu-devel@nongnu.org>; Wed, 11 Aug 2010 10:14:35 GMT
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o7BAESlS1581154
	for <qemu-devel@nongnu.org>; Wed, 11 Aug 2010 11:14:34 +0100
Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o7BAEScE010483
	for <qemu-devel@nongnu.org>; Wed, 11 Aug 2010 11:14:28 +0100
Date: Wed, 11 Aug 2010 11:14:27 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20100811101427.GA2262@stefan-thinkpad.transitives.com>
References: <20100811135502.1a51f73a@zephyr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100811135502.1a51f73a@zephyr>
Subject: [Qemu-devel] Re: [Tracing] More Trace events
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: Mahesh <mahesh@linux.vnet.ibm.com>, Ananth Narayan <ananth@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On Wed, Aug 11, 2010 at 01:55:02PM +0530, Prerna Saxena wrote:
> This patch adds few more trace events for tracking IO and also to trace 
> balloon event flagged via the monitor.
> 
> Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
> ---

Thanks for adding these trace events.  Two minor requests:
1. Please split the patch into one patch that adds ioport tracing and
   one that adds virtio-balloon tracing.  If there is discussion related
   to one of these subsystems any follow up will be cleaner and only
   affect that commit.

> diff --git a/trace-events b/trace-events
> index 80197b6..cade0b5 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -59,3 +59,11 @@ virtio_blk_handle_write(void *req, unsigned long sector, unsigned long nsectors)
> 
>  # posix-aio-compat.c
>  paio_submit(void *acb, void *opaque, unsigned long sector_num, unsigned long nb_sectors, unsigned long type) "acb %p opaque %p sector_num %lu nb_sectors %lu type %lu"
> +
> +# ioport.c
> +cpu_in(unsigned int addr, unsigned int val) "Addr %u Value %u"
> +cpu_out(unsigned int addr, unsigned int val) "Addr %u Value %u"
> +
> +# balloon.c
> +# Since requests are raised via monitor, not many tracepoints are needed.
> +balloon_event(void *opaque, unsigned long addr) "Opaque %p Addr %lu"

2. Please follow the lowercase format string convention.  All other
   trace events use lowercase "like %p this %u".

Thanks,
Stefan