From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34989 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnTz4-0005wy-7K
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 06:10:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1OnTz3-0002YE-7M
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 06:10:30 -0400
Received: from mtagate6.de.ibm.com ([195.212.17.166]:57654)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1OnTz2-0002Xq-U6
	for qemu-devel@nongnu.org; Mon, 23 Aug 2010 06:10:29 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com
	(d12nrmr1607.megacenter.de.ibm.com [9.149.167.49])
	by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id o7NAAL0R016093
	for <qemu-devel@nongnu.org>; Mon, 23 Aug 2010 10:10:21 GMT
Received: from d12av01.megacenter.de.ibm.com (d12av01.megacenter.de.ibm.com
	[9.149.165.212])
	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o7NAALqI3874872
	for <qemu-devel@nongnu.org>; Mon, 23 Aug 2010 12:10:21 +0200
Received: from d12av01.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o7NAAKsP023075
	for <qemu-devel@nongnu.org>; Mon, 23 Aug 2010 12:10:21 +0200
Date: Mon, 23 Aug 2010 11:10:19 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 06/14] trace: Trace entry point of balloon
	request handler
Message-ID: <20100823101019.GB2335@stefan-thinkpad.transitives.com>
References: <1281609395-17621-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1281609395-17621-7-git-send-email-stefanha@linux.vnet.ibm.com>
	<4C719998.6030203@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C719998.6030203@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Julien Desfossez <ju@klipix.org>, qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>

On Sun, Aug 22, 2010 at 04:41:44PM -0500, Anthony Liguori wrote:
> ram_addr_t is not necessarily an unsigned long.  It's actually a
> uint64_t.   Integer promotion should handle this in most cases but
> having the definition in two different places worries me a bit.

I thought it is unsigned long:

cpu-common.h:typedef unsigned long ram_addr_t;

ram_addr_t cannot be used explicitly because it is only defined for
softmmu targets.  User-only builds do not define ram_addr_t and the
generated trace.h header would break the compile.

This is a more general weakness of the tracing system: it is fragile
under #ifdefed builds because it tries to work for softmmu, user-only,
and qemu-tools!  Perhaps we should split the trace-events file.

Stefan