From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52482 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OntX1-0006wR-NB for qemu-devel@nongnu.org; Tue, 24 Aug 2010 09:27:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OntX0-0000jY-II for qemu-devel@nongnu.org; Tue, 24 Aug 2010 09:27:15 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:36004) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OntX0-0000jU-Ex for qemu-devel@nongnu.org; Tue, 24 Aug 2010 09:27:14 -0400 Received: by qyk31 with SMTP id 31so5568355qyk.4 for ; Tue, 24 Aug 2010 06:27:14 -0700 (PDT) Date: Tue, 24 Aug 2010 21:27:10 +0800 From: Ken CC Message-ID: <20100824132710.GB19469@kt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100824132525.GA19469@kt> Subject: [Qemu-devel] [PATCH 2/4] pci init: fail qemu if devfn exceeding the max function number supported on bus List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: yamahata@valinux.co.jp, avi@redhat.com, kvm@vger.kernel.org Cc: qemu-devel@nongnu.org, mst@redhat.com Check if devfn < PCIBUS_MAX_DEVICES * PCI_FUNCTIONS_PER_DEVICE Signed-off-by: Ken CC --- hw/pci.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 9234fe3..fc4becd 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -747,6 +747,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus, PCIConfigWriteFunc *config_write, bool is_bridge) { + assert(devfn / PCI_FUNCTIONS_PER_DEVICE < PCIBUS_MAX_DEVICES); if (devfn < 0) { for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices); devfn += PCI_FUNC_MAX) {