From: Isaku Yamahata <yamahata@valinux.co.jp>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alex Williamson <alex.williamson@redhat.com>,
glommer@redhat.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qdev: Reset hotplugged devices
Date: Wed, 25 Aug 2010 12:07:52 +0900 [thread overview]
Message-ID: <20100825030752.GA14605@valinux.co.jp> (raw)
In-Reply-To: <4C6EA5C9.8080700@codemonkey.ws>
On Fri, Aug 20, 2010 at 10:56:57AM -0500, Anthony Liguori wrote:
> The real problem is how we do reset. We shouldn't register a reset
> handler for every qdev device but rather register a single reset handler
> that walks the device tree and calls reset on every reachable device.
>
> Then we can always call reset in init() and there's no need to have a
> dev->hotplugged check. The qdev device tree reset handler should not be
> registered until *after* we call qemu_system_reset() after creating the
> device model which will ensure that we don't do a double reset.
I don't see why you re-invent the patch.
Please see the patches I sent out on August 5.
http://lists.nongnu.org/archive/html/qemu-devel/2010-08/msg00377.html
http://lists.nongnu.org/archive/html/qemu-devel/2010-08/msg00383.html
Maybe we can merge the patches.
As for your patch, I have some comment.
- bus itself may want its own handler. At lease pci bus needs it.
And propagating reset signal to children is up to the bus controller.
- child devices should be reset before parent.
This doesn't matter much though.
--
yamahata
next prev parent reply other threads:[~2010-08-25 2:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 16:19 [Qemu-devel] [PATCH] qdev: Reset hotplugged devices Alex Williamson
2010-08-03 17:41 ` [Qemu-devel] " Glauber Costa
2010-08-20 9:00 ` [Qemu-devel] " Markus Armbruster
2010-08-20 12:41 ` Alex Williamson
2010-08-20 15:47 ` Markus Armbruster
2010-08-20 15:56 ` Anthony Liguori
2010-08-20 16:14 ` Markus Armbruster
2010-08-20 18:12 ` Anthony Liguori
2010-08-20 22:05 ` Alex Williamson
2010-08-21 10:07 ` Markus Armbruster
2010-08-21 15:19 ` Anthony Liguori
2010-08-23 11:25 ` [Qemu-devel] " Paolo Bonzini
2010-08-23 13:27 ` Anthony Liguori
2010-08-25 3:07 ` Isaku Yamahata [this message]
2010-08-25 12:55 ` [Qemu-devel] " Anthony Liguori
2010-08-25 15:17 ` Isaku Yamahata
2010-08-25 16:49 ` Anthony Liguori
2010-08-26 8:38 ` Isaku Yamahata
2010-08-26 13:02 ` Anthony Liguori
2010-08-27 3:52 ` Isaku Yamahata
2010-08-27 17:43 ` Wei Xu
2010-08-27 7:28 ` Isaku Yamahata
2010-08-26 13:04 ` Anthony Liguori
2010-08-26 13:15 ` Avi Kivity
2010-08-26 13:25 ` Anthony Liguori
2010-08-26 14:29 ` Avi Kivity
2010-08-26 17:39 ` Blue Swirl
2010-08-23 12:00 ` Avi Kivity
2010-08-23 12:21 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825030752.GA14605@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).