From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58914 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OoXbT-0006EE-OQ for qemu-devel@nongnu.org; Thu, 26 Aug 2010 04:14:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OoXbS-0001x5-GK for qemu-devel@nongnu.org; Thu, 26 Aug 2010 04:14:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34583) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoXbS-0001wn-88 for qemu-devel@nongnu.org; Thu, 26 Aug 2010 04:14:30 -0400 Date: Thu, 26 Aug 2010 09:14:25 +0100 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped Message-ID: <20100826081425.GD9564@redhat.com> References: <8450ea8e785c9049f0b3edddc01650a8c4b9ffe7.1282265244.git.amit.shah@redhat.com> <4C719C7E.6030606@codemonkey.ws> <20100826060513.GF18351@amit-laptop.redhat.com> <4C762058.8070301@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C762058.8070301@redhat.com> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Amit Shah , Juan Quintela , qemu list , agl@us.ibm.com On Thu, Aug 26, 2010 at 10:05:44AM +0200, Paolo Bonzini wrote: > On 08/26/2010 08:05 AM, Amit Shah wrote: > >This is what I have currently. It would need some timer handling in > >the save/load case as well, right? > > When loading you won't have any pending "info balloon" command, so I > think the timer need not be preserved across migration. > > Also, 5 seconds for a stopped guest is actually a lot, so maybe Amit's > original patch or a variant thereof would make sense anyway. We should have a combination of both. If we know the guest is stopped we should return immediately, otherwise we should use the timer as a way to cope with a crashed/evil guest. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|