From: Amit Shah <amit.shah@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: agl@us.ibm.com, qemu list <qemu-devel@nongnu.org>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped
Date: Thu, 26 Aug 2010 13:47:50 +0530 [thread overview]
Message-ID: <20100826081750.GK18351@amit-laptop.redhat.com> (raw)
In-Reply-To: <4C762058.8070301@redhat.com>
On (Thu) Aug 26 2010 [10:05:44], Paolo Bonzini wrote:
> On 08/26/2010 08:05 AM, Amit Shah wrote:
> >This is what I have currently. It would need some timer handling in
> >the save/load case as well, right?
>
> When loading you won't have any pending "info balloon" command, so I
> think the timer need not be preserved across migration.
>
> Also, 5 seconds for a stopped guest is actually a lot,
That's the problem; it's policy. Where and how to specify it?
> so maybe
> Amit's original patch or a variant thereof would make sense anyway.
This seems to be needed though -- as Anthony mentioned, a guest which
has oopsed or similar, incapable of servicing the stats request, is
going to block the monitor command from returning forever.
So it's better to have a timeout, just that we need to decide how much
it should be.
Amit
next prev parent reply other threads:[~2010-08-26 8:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 0:48 [Qemu-devel] [PATCH V2] balloon: Don't try fetching info if machine is stopped Amit Shah
2010-08-20 10:13 ` [Qemu-devel] " Paolo Bonzini
2010-08-20 12:01 ` [Qemu-devel] " Amit Shah
2010-08-22 21:54 ` Anthony Liguori
2010-08-23 9:24 ` Daniel P. Berrange
2010-08-26 5:25 ` Amit Shah
2010-08-26 6:05 ` Amit Shah
2010-08-26 8:05 ` Paolo Bonzini
2010-08-26 8:14 ` Daniel P. Berrange
2010-08-26 13:22 ` Anthony Liguori
2010-08-26 8:17 ` Amit Shah [this message]
2010-08-26 8:19 ` Paolo Bonzini
2010-08-26 8:28 ` Daniel P. Berrange
2010-08-26 12:57 ` Luiz Capitulino
2010-08-26 13:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826081750.GK18351@amit-laptop.redhat.com \
--to=amit.shah@redhat.com \
--cc=agl@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).