From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42609 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OovG0-0000Yr-5K for qemu-devel@nongnu.org; Fri, 27 Aug 2010 05:30:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OovFu-0004ZB-0r for qemu-devel@nongnu.org; Fri, 27 Aug 2010 05:29:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39311) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OovFt-0004Z5-Qq for qemu-devel@nongnu.org; Fri, 27 Aug 2010 05:29:49 -0400 Date: Fri, 27 Aug 2010 10:29:45 +0100 From: "Daniel P. Berrange" Message-ID: <20100827092945.GC22361@redhat.com> References: <51ec99ce2db02aeb34ec6683a76895b4a127057d.1282886503.git.amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51ec99ce2db02aeb34ec6683a76895b4a127057d.1282886503.git.amit.shah@redhat.com> Subject: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Paolo Bonzini , agl@us.ibm.com, qemu list , Luiz Capitulino On Fri, Aug 27, 2010 at 10:57:10AM +0530, Amit Shah wrote: > This error message denotes some command was not successful in completing > as the guest was unresponsive. > > Use it in the virtio-balloon code when showing older, cached data. > > Signed-off-by: Amit Shah > --- > hw/virtio-balloon.c | 1 + > qerror.c | 4 ++++ > qerror.h | 3 +++ > 3 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c > index d6c66cf..309c343 100644 > --- a/hw/virtio-balloon.c > +++ b/hw/virtio-balloon.c > @@ -140,6 +140,7 @@ static void complete_stats_request(VirtIOBalloon *vb) > > static void show_old_stats(void *opaque) > { > + qerror_report(QERR_MACHINE_STOPPED); > complete_stats_request(opaque); > } NACK. It has always been allowed & valid to call query-balloon to get the current balloon level. We must not throw an error just because the recently added mem stats can't be refreshed. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|