From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52158 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oox44-0006HZ-R7 for qemu-devel@nongnu.org; Fri, 27 Aug 2010 07:25:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oox43-0003mY-8T for qemu-devel@nongnu.org; Fri, 27 Aug 2010 07:25:44 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:40869) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oox42-0003mH-E5 for qemu-devel@nongnu.org; Fri, 27 Aug 2010 07:25:43 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp08.in.ibm.com (8.14.4/8.13.1) with ESMTP id o7RBAsa4002133 for ; Fri, 27 Aug 2010 16:40:54 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o7RBPXYn2543844 for ; Fri, 27 Aug 2010 16:55:34 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o7RBPXS5018233 for ; Fri, 27 Aug 2010 21:25:33 +1000 Date: Fri, 27 Aug 2010 16:53:15 +0530 From: Prerna Saxena Message-ID: <20100827165315.4cd2a0c9@zephyr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH][Tracing v2] Process -trace using QemuOptsList List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Mahesh , Ananth Narayan , Stefan Hajnoczi [PATCH] Add -trace file FILENAME switch to qemu startup command. This processes the argument using QemuOptsList Signed-off-by: Prerna Saxena --- qemu-config.c | 18 ++++++++++++++++++ qemu-config.h | 3 +++ vl.c | 5 ++++- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 95abe61..9106511 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -294,6 +294,21 @@ QemuOptsList qemu_mon_opts = { }, }; +#ifdef CONFIG_SIMPLE_TRACE +QemuOptsList qemu_trace_opts = { + .name = "trace", + .implied_opt_name = "trace", + .head = QTAILQ_HEAD_INITIALIZER(qemu_trace_opts.head), + .desc = { + { + .name = "file", + .type = QEMU_OPT_STRING, + }, + { /* end if list */ } + }, +}; +#endif + QemuOptsList qemu_cpudef_opts = { .name = "cpudef", .head = QTAILQ_HEAD_INITIALIZER(qemu_cpudef_opts.head), @@ -352,6 +367,9 @@ static QemuOptsList *vm_config_groups[] = { &qemu_global_opts, &qemu_mon_opts, &qemu_cpudef_opts, +#ifdef CONFIG_SIMPLE_TRACE + &qemu_trace_opts, +#endif NULL, }; diff --git a/qemu-config.h b/qemu-config.h index dca69d4..4db2fb5 100644 --- a/qemu-config.h +++ b/qemu-config.h @@ -14,6 +14,9 @@ extern QemuOptsList qemu_rtc_opts; extern QemuOptsList qemu_global_opts; extern QemuOptsList qemu_mon_opts; extern QemuOptsList qemu_cpudef_opts; +#ifdef CONFIG_SIMPLE_TRACE +extern QemuOptsList qemu_trace_opts; +#endif QemuOptsList *qemu_find_opts(const char *group); int qemu_set_option(const char *str); diff --git a/vl.c b/vl.c index 99664e9..0ff04e9 100644 --- a/vl.c +++ b/vl.c @@ -2599,7 +2599,10 @@ int main(int argc, char **argv, char **envp) break; #ifdef CONFIG_SIMPLE_TRACE case QEMU_OPTION_trace: - trace_file = optarg; + opts = qemu_opts_parse(&qemu_trace_opts, optarg, 0); + if (opts) { + trace_file = qemu_opt_get(opts, "file"); + } break; #endif case QEMU_OPTION_readconfig: -- 1.7.2.1 -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India