From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42384 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Op9gK-0003ab-TJ for qemu-devel@nongnu.org; Fri, 27 Aug 2010 20:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Op9gF-0001Jy-TV for qemu-devel@nongnu.org; Fri, 27 Aug 2010 20:54:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55360) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Op9gF-0001Js-Ku for qemu-devel@nongnu.org; Fri, 27 Aug 2010 20:53:59 -0400 Date: Sat, 28 Aug 2010 06:22:43 +0530 From: Amit Shah Message-ID: <20100828005243.GB415@amit-laptop.redhat.com> References: <51ec99ce2db02aeb34ec6683a76895b4a127057d.1282886503.git.amit.shah@redhat.com> <20100827092945.GC22361@redhat.com> <4C77B209.6050902@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C77B209.6050902@codemonkey.ws> Subject: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , agl@us.ibm.com, qemu list , Luiz Capitulino On (Fri) Aug 27 2010 [07:39:37], Anthony Liguori wrote: > > > >NACK. It has always been allowed& valid to call query-balloon > >to get the current balloon level. We must not throw an error > >just because the recently added mem stats can't be refreshed. > > I think that's a fair comment but why even bother fixing the > command. Let's introduce a new command that just gets a single > piece of information instead of having a command return lots of > information. Instead, let's have query-balloon do the same thing as it did in 0.12 and add a new command for 0.13 (query-balloon-stats) that does the stats with timeout? That way we won't have regressions from 0.12 and have the new behaviour only for 0.13, which we can say is 'experimental'. Amit