From: Isaku Yamahata <yamahata@valinux.co.jp>
To: seabios@seabios.org
Cc: Cam Macdonell <cam@cs.ualberta.ca>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr().
Date: Mon, 30 Aug 2010 11:32:01 +0900 [thread overview]
Message-ID: <20100830023201.GB22847@valinux.co.jp> (raw)
old_addr is initialized, but not used.
remove the useless variable.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
src/pciinit.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/pciinit.c b/src/pciinit.c
index f75e552..0346423 100644
--- a/src/pciinit.c
+++ b/src/pciinit.c
@@ -39,12 +39,10 @@ static u32 pci_bar(u16 bdf, int region_num)
static void pci_set_io_region_addr(u16 bdf, int region_num, u32 addr)
{
- u32 ofs, old_addr;
+ u32 ofs;
ofs = pci_bar(bdf, region_num);
- old_addr = pci_config_readl(bdf, ofs);
-
pci_config_writel(bdf, ofs, addr);
dprintf(1, "region %d: 0x%08x\n", region_num, addr);
}
--
1.7.1.1
next reply other threads:[~2010-08-30 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 2:32 Isaku Yamahata [this message]
2010-09-03 1:40 ` [Qemu-devel] Re: [SeaBIOS] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr() Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100830023201.GB22847@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=cam@cs.ualberta.ca \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).