qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: jes.sorensen@redhat.com, kraxel@redhat.com,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx
Date: Wed, 1 Sep 2010 13:40:25 +0300	[thread overview]
Message-ID: <20100901104025.GC7513@redhat.com> (raw)
In-Reply-To: <1283293567.5826.147.camel@x201>

On Tue, Aug 31, 2010 at 04:26:07PM -0600, Alex Williamson wrote:
> On Tue, 2010-08-31 at 16:33 -0500, Anthony Liguori wrote:
> > On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote:
> > > On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote:
> > >    
> > >> Add the ability to configure the tx_timer timeout and add a bottom
> > >> half tx handler that typically shows a nice perf boost over the
> > >> time based approach.  See last patch for perf details.  Make this
> > >> the new default when the iothread is enabled.  Thanks,
> > >>
> > >> Alex
> > >>      
> > > As a further thought, maybe it would help to have a
> > > separate namespace for unsupported, developer-only parameters.
> > > Thoughts?
> > >    
> > 
> > We already have an undocumented one, just prefix with 'x-' to indicate 
> > that it's experimental.
> 
> Any objection then to x-txburst and x-txtimer then?  Easy enough to
> rename.  Thanks,
> 
> Alex

No objection. Let's put the 256 constant in a header,
with a comment explaining where it came from?

-- 
MST

      reply	other threads:[~2010-09-01 10:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 22:36 [Qemu-devel] [PATCH 0/5] virtio-net: More configurability and bh handling for tx Alex Williamson
2010-08-27 22:37 ` [Qemu-devel] [PATCH 1/5] virtio-net: Make tx_timer timeout configurable Alex Williamson
2010-08-31 18:00   ` Chris Wright
2010-08-31 18:07     ` Alex Williamson
2010-08-31 19:29       ` Chris Wright
2010-08-27 22:37 ` [Qemu-devel] [PATCH 2/5] virtio-net: Limit number of packets sent per TX flush Alex Williamson
2010-08-31 20:23   ` [Qemu-devel] " Michael S. Tsirkin
2010-08-27 22:37 ` [Qemu-devel] [PATCH 3/5] virtio-net: Rename tx_timer_active to tx_waiting Alex Williamson
2010-08-27 22:37 ` [Qemu-devel] [PATCH 4/5] virtio-net: Introduce a new bottom half packet TX Alex Williamson
2010-08-31 20:14   ` [Qemu-devel] " Michael S. Tsirkin
2010-08-31 20:33     ` Alex Williamson
2010-09-01  9:47       ` Michael S. Tsirkin
2010-08-27 22:37 ` [Qemu-devel] [PATCH 5/5] virtio-net: Switch default to new bottom half TX handler for iothread Alex Williamson
2010-08-31 20:25   ` [Qemu-devel] " Michael S. Tsirkin
2010-08-31 22:32     ` Alex Williamson
2010-08-31 22:46       ` Anthony Liguori
2010-09-01  6:21       ` Stefan Hajnoczi
2010-09-01  8:47       ` Michael S. Tsirkin
2010-08-31 20:20 ` [Qemu-devel] Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx Michael S. Tsirkin
2010-08-31 20:27 ` Michael S. Tsirkin
2010-08-31 21:33   ` Anthony Liguori
2010-08-31 22:26     ` Alex Williamson
2010-09-01 10:40       ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100901104025.GC7513@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=jes.sorensen@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).