From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41922 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OrCSQ-0004CW-GE
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 12:16:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <edgmnt@gmail.com>) id 1OrCSL-0000Qs-8i
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 12:16:06 -0400
Received: from mail-fx0-f45.google.com ([209.85.161.45]:56581)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <edgmnt@gmail.com>) id 1OrCSL-0000Qi-2L
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 12:16:05 -0400
Received: by fxm7 with SMTP id 7so381234fxm.4
	for <qemu-devel@nongnu.org>; Thu, 02 Sep 2010 09:16:04 -0700 (PDT)
Sender: Eduard - Gabriel Munteanu <edgmnt@gmail.com>
Date: Thu, 2 Sep 2010 19:14:00 +0300
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support
Message-ID: <20100902161400.GA7591@localhost>
References: <AANLkTinMgs-DT3pQ0++YmLVPVA_TugyJfMuheOk5VWtG@mail.gmail.com>
	<1283119703-9781-1-git-send-email-eduard.munteanu@linux360.ro>
	<4C7EB336.40003@mail.berlios.de> <20100902085104.GB7211@localhost>
	<4C7FCB53.5010503@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C7FCB53.5010503@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: kvm@vger.kernel.org, mst@redhat.com, joro@8bytes.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, yamahata@valinux.co.jp, paul@codesourcery.com, avi@redhat.com

On Thu, Sep 02, 2010 at 06:05:39PM +0200, Stefan Weil wrote:
> Am 02.09.2010 10:51, schrieb Eduard - Gabriel Munteanu:

[snip]

> >> The functions pci_memory_read and pci_memory_write not only read
> >> or write byte data but many different data types which leads to
> >> a lot of type casts in your other patches.
> >>
> >> I'd prefer "void *buf" and "const void *buf" in the argument lists.
> >> Then all those type casts could be removed.
> >>
> >> Regards
> >> Stefan Weil
> >>      
> > I only followed an approach similar to how cpu_physical_memory_{read,write}()
> > is defined. I think I should change both cpu_physical_memory_* stuff and
> > pci_memory_* stuff, not only the latter, if I decide to go on that
> > approach.
> >
> >
> > 	Eduard
> >    
> 
> 
> Yes, cpu_physical_memory_read, cpu_physical_memory_write
> and cpu_physical_memory_rw should be changed, too.
> 
> They also require several type casts today.
> 
> But this change can be done in an independent patch.
> 
> Stefan

Roger, I'm on it. The existing casts could remain there AFAICT, so it's
a pretty simple change.


	Eduard