From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58708 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OrD0K-0007s6-6W
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 12:52:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <hch@lst.de>) id 1OrD0F-000863-Bw
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 12:51:08 -0400
Received: from verein.lst.de ([213.95.11.210]:53584)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <hch@lst.de>)
	id 1OrD0F-00085Y-2X
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 12:51:07 -0400
Date: Thu, 2 Sep 2010 18:50:59 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] raw-posix: Don't use file name for
	host_cdrom detection on Linux
Message-ID: <20100902165059.GA31885@lst.de>
References: <1283442609-11902-1-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1283442609-11902-1-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Sep 02, 2010 at 05:50:09PM +0200, Kevin Wolf wrote:
> On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose
> anything but false positives by removing the check for a /dev/cd* path.

Agreed.


Reviewed-by: Christoph Hellwig <hch@lst.de>