* [Qemu-devel] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr().
@ 2010-08-30 2:32 Isaku Yamahata
2010-09-03 1:40 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
0 siblings, 1 reply; 2+ messages in thread
From: Isaku Yamahata @ 2010-08-30 2:32 UTC (permalink / raw)
To: seabios; +Cc: Cam Macdonell, qemu-devel
old_addr is initialized, but not used.
remove the useless variable.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
src/pciinit.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/pciinit.c b/src/pciinit.c
index f75e552..0346423 100644
--- a/src/pciinit.c
+++ b/src/pciinit.c
@@ -39,12 +39,10 @@ static u32 pci_bar(u16 bdf, int region_num)
static void pci_set_io_region_addr(u16 bdf, int region_num, u32 addr)
{
- u32 ofs, old_addr;
+ u32 ofs;
ofs = pci_bar(bdf, region_num);
- old_addr = pci_config_readl(bdf, ofs);
-
pci_config_writel(bdf, ofs, addr);
dprintf(1, "region %d: 0x%08x\n", region_num, addr);
}
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Qemu-devel] Re: [SeaBIOS] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr().
2010-08-30 2:32 [Qemu-devel] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr() Isaku Yamahata
@ 2010-09-03 1:40 ` Kevin O'Connor
0 siblings, 0 replies; 2+ messages in thread
From: Kevin O'Connor @ 2010-09-03 1:40 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: seabios, Cam Macdonell, qemu-devel
On Mon, Aug 30, 2010 at 11:32:01AM +0900, Isaku Yamahata wrote:
> old_addr is initialized, but not used.
> remove the useless variable.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Thanks.
-Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-03 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-30 2:32 [Qemu-devel] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr() Isaku Yamahata
2010-09-03 1:40 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).