From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic
Date: Tue, 7 Sep 2010 16:12:17 +0200 [thread overview]
Message-ID: <20100907141216.GA2177@amd.com> (raw)
In-Reply-To: <4C864365.30301@redhat.com>
On Tue, Sep 07, 2010 at 09:51:33AM -0400, Avi Kivity wrote:
> On 09/07/2010 03:23 PM, Alexander Graf wrote:
> >
> > I think we should get rid of kvm_nested and -enable-nesting. Instead, we should enable the SVM bit in the "host" and "qemu64" cpu types, but not in "kvm64". This way users are safe to not use nested svm, but can choose to do so if they like.
> >
> > Also, it should be possible to do something like -cpu kvm64,flags=+svm. Without having to mess with -enable-nesting.
>
> I agree, -enable-nesting is redundant with -cpu ,+svm.
This patchset makes -enable-nesting pratically a synonym for -cpu ,+svm.
So we can safely remove -enable-nesting in the future.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-09-07 14:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 11:27 [Qemu-devel] [PATCH 0/3] Add svm cpuid features to qemu-kvm Joerg Roedel
2010-09-07 11:27 ` [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic Joerg Roedel
2010-09-07 12:23 ` Alexander Graf
2010-09-07 12:30 ` Daniel P. Berrange
2010-09-07 12:33 ` Alexander Graf
2010-09-07 12:35 ` Avi Kivity
2010-09-07 12:37 ` Alexander Graf
2010-09-07 12:43 ` Avi Kivity
2010-09-07 12:55 ` Alexander Graf
2010-09-07 12:59 ` Avi Kivity
2010-09-07 14:14 ` Roedel, Joerg
2010-09-07 13:51 ` Avi Kivity
2010-09-07 14:12 ` Roedel, Joerg [this message]
2010-09-07 14:14 ` Alexander Graf
2010-09-07 14:18 ` Roedel, Joerg
2010-09-07 14:16 ` Alexander Graf
2010-09-07 14:20 ` Roedel, Joerg
2010-09-07 14:22 ` Alexander Graf
2010-09-07 14:33 ` Roedel, Joerg
2010-09-07 14:36 ` Alexander Graf
2010-09-07 14:56 ` Avi Kivity
2010-09-07 11:27 ` [Qemu-devel] [PATCH 2/3] qemu-kvm: Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-07 11:27 ` [Qemu-devel] [PATCH 3/3] qemu-kvm: Add svm cpuid features Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907141216.GA2177@amd.com \
--to=joerg.roedel@amd.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).