From: pradeepkumar <psuriset@linux.vnet.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: skannery@in.ibm.com, rharper@us.ibm.com, qemu-devel@nongnu.org,
kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Device hotplug issues
Date: Tue, 7 Sep 2010 18:07:02 +0530 [thread overview]
Message-ID: <20100907180702.41d6e757@skywalker-laptop> (raw)
In-Reply-To: <4C85C9A2.2040701@redhat.com>
Hi
I tried to add a device to guest from upstream qemu monitor using
"device_add".
when i try to add VGA, vmware-svga..etc, from qemu monitor my qemu
monitor is aborted, Since these devices already registered.
I dont see a reason to kill monitor. I think abort() is a bit rough.
we need a better way to handle it. If a user try to add a already
registered device, qemu should convey this to user saying that, this
device already registered and an error message should be fine than
aborting qemu.
QLIST_FOREACH(block, &ram_list.blocks, next) {
if (!strcmp(block->idstr, new_block->idstr)) {
fprintf(stderr, "RAMBlock \"%s\" already registered,
abort!\n",
new_block->idstr);
abort();
}
Thanks
Pradeep
prev parent reply other threads:[~2010-09-07 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 20:00 [Qemu-devel] KVM call agenda for September 7 Juan Quintela
2010-09-07 5:12 ` [Qemu-devel] " Avi Kivity
2010-09-07 12:37 ` pradeepkumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907180702.41d6e757@skywalker-laptop \
--to=psuriset@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rharper@us.ibm.com \
--cc=skannery@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).