qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] powerpc: Avoid TLB related log spamming
@ 2010-09-11 12:38 Edgar E. Iglesias
  2010-09-11 13:19 ` Alexander Graf
  0 siblings, 1 reply; 3+ messages in thread
From: Edgar E. Iglesias @ 2010-09-11 12:38 UTC (permalink / raw)
  To: qemu-devel, edgar.iglesias

Invalid TLB entries are normal and should not spam the log.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
---
 target-ppc/helper.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index d342b09..a7ec1f4 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -1050,7 +1050,6 @@ static inline int ppcemb_tlb_check(CPUState *env, ppcemb_tlb_t *tlb,
 
     /* Check valid flag */
     if (!(tlb->prot & PAGE_VALID)) {
-        qemu_log("%s: TLB %d not valid\n", __func__, i);
         return -1;
     }
     mask = ~(tlb->size - 1);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] powerpc: Avoid TLB related log spamming
  2010-09-11 12:38 [Qemu-devel] [PATCH] powerpc: Avoid TLB related log spamming Edgar E. Iglesias
@ 2010-09-11 13:19 ` Alexander Graf
  2010-09-11 13:25   ` Edgar E. Iglesias
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2010-09-11 13:19 UTC (permalink / raw)
  To: Edgar E.Iglesias; +Cc: qemu-devel

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]


On 11.09.2010, at 14:38, Edgar E. Iglesias wrote:

> Invalid TLB entries are normal and should not spam the log.

Thanks, applied to my ppc tree:

  git://repo.or.cz/qemu/agraf.git ppc-next


Alex


[-- Attachment #2: Type: text/html, Size: 595 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] powerpc: Avoid TLB related log spamming
  2010-09-11 13:19 ` Alexander Graf
@ 2010-09-11 13:25   ` Edgar E. Iglesias
  0 siblings, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2010-09-11 13:25 UTC (permalink / raw)
  To: Alexander Graf; +Cc: qemu-devel

On Sat, Sep 11, 2010 at 03:19:57PM +0200, Alexander Graf wrote:
>    On 11.09.2010, at 14:38, Edgar E. Iglesias wrote:
> 
>    Invalid TLB entries are normal and should not spam the log.
> 
>    Thanks, applied to my ppc tree:
>      [1]git://repo.or.cz/qemu/agraf.git ppc-next
>    Alex

Thanks Alex,

I applied this to upstream as a small obvious patch. The soon to
come MMU patches should definitely go through your tree though.

Cheers,
Edgar

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-09-11 13:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-11 12:38 [Qemu-devel] [PATCH] powerpc: Avoid TLB related log spamming Edgar E. Iglesias
2010-09-11 13:19 ` Alexander Graf
2010-09-11 13:25   ` Edgar E. Iglesias

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).