From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60781 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OuRHq-0002Z2-Bh for qemu-devel@nongnu.org; Sat, 11 Sep 2010 10:42:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OuRHc-0000On-7m for qemu-devel@nongnu.org; Sat, 11 Sep 2010 10:42:25 -0400 Received: from 8bytes.org ([88.198.83.132]:38006) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OuRHc-0000Oi-1N for qemu-devel@nongnu.org; Sat, 11 Sep 2010 10:42:24 -0400 Date: Sat, 11 Sep 2010 16:42:23 +0200 From: Joerg Roedel Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features Message-ID: <20100911144222.GC680@8bytes.org> References: <1284133120-19453-1-git-send-email-joerg.roedel@amd.com> <1284133120-19453-3-git-send-email-joerg.roedel@amd.com> <20100911142018.GA680@8bytes.org> <20100911143634.GB680@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Joerg Roedel , Marcelo Tosatti , Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org On Sat, Sep 11, 2010 at 04:38:51PM +0200, Alexander Graf wrote: > > I am not sure that I am the right person to do such an invasive change. > > At least not in this patch-set. I could think of removing SVM from the > > qemu64 definition and add it again in the TCG specific path. > > It's not an invasive change and IMHO the only correct one. I'm not > even sure why it's not done yet - after all the reason for the kvm* > cpu types is exactly that. Please just add it as an early patch in > your series. Okay, if you say its ok I will change it. But if anyone comes to me with regressions I will send them straight to you :-P Joerg