From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40190 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OuoT9-00014O-NQ
	for qemu-devel@nongnu.org; Sun, 12 Sep 2010 11:27:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OuoT8-0006he-Iq
	for qemu-devel@nongnu.org; Sun, 12 Sep 2010 11:27:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13721)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OuoT8-0006hY-CV
	for qemu-devel@nongnu.org; Sun, 12 Sep 2010 11:27:50 -0400
Date: Sun, 12 Sep 2010 17:21:51 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100912152151.GB5092@redhat.com>
References: <cover.1284000417.git.yamahata@valinux.co.jp>
	<f7f3ce7655c480886e291c4da2013f77e68602ed.1284000417.git.yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f7f3ce7655c480886e291c4da2013f77e68602ed.1284000417.git.yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH 3/3] pci: improve signature of
	pci_register_bar().
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Thu, Sep 09, 2010 at 11:48:57AM +0900, Isaku Yamahata wrote:
> Make type uint8_t from int because PCIIORegion::type is uint8_t.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
>  hw/pci.c |    2 +-
>  hw/pci.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)


Applied, thanks.

> diff --git a/hw/pci.c b/hw/pci.c
> index 31eba9a..ceee291 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -758,7 +758,7 @@ static int pci_unregister_device(DeviceState *dev)
>  }
>  
>  void pci_register_bar(PCIDevice *pci_dev, int region_num,
> -                            pcibus_t size, int type,
> +                            pcibus_t size, uint8_t type,
>                              PCIMapIORegionFunc *map_func)
>  {
>      PCIIORegion *r;
> diff --git a/hw/pci.h b/hw/pci.h
> index bccab3a..25179eb 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -192,7 +192,7 @@ PCIDevice *pci_register_device(PCIBus *bus, const char *name,
>                                 PCIConfigWriteFunc *config_write);
>  
>  void pci_register_bar(PCIDevice *pci_dev, int region_num,
> -                            pcibus_t size, int type,
> +                            pcibus_t size, uint8_t type,
>                              PCIMapIORegionFunc *map_func);
>  
>  int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
> -- 
> 1.7.1.1