From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35518 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ov6So-0005Oz-RO
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 06:40:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Ov6Sn-0006dS-Mz
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 06:40:42 -0400
Received: from mtagate1.uk.ibm.com ([194.196.100.161]:57590)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Ov6Sn-0006d1-G3
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 06:40:41 -0400
Received: from d06nrmr1707.portsmouth.uk.ibm.com
	(d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225])
	by mtagate1.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o8DAecuY005083
	for <qemu-devel@nongnu.org>; Mon, 13 Sep 2010 10:40:38 GMT
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o8DAeXDU3547272
	for <qemu-devel@nongnu.org>; Mon, 13 Sep 2010 11:40:38 +0100
Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o8DAeWx2029157
	for <qemu-devel@nongnu.org>; Mon, 13 Sep 2010 11:40:33 +0100
Date: Mon, 13 Sep 2010 11:40:32 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20100913104031.GA3339@stefan-thinkpad.transitives.com>
References: <1284304896-3239-1-git-send-email-andreas.faerber@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1284304896-3239-1-git-send-email-andreas.faerber@web.de>
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] trace: Fix user emulator dependency on
	trace objects
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <andreas.faerber@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Prerna Saxena <prerna@linux.vnet.ibm.com>

On Sun, Sep 12, 2010 at 05:21:36PM +0200, Andreas F=E4rber wrote:
> On a clean build, after generating trace.h, make would recurse into *-*=
-user
> without a clue how to build ../trace.o (added to $(obj-y) in Makefile.t=
arget)
> since its generation rule is in the main Makefile.
> The softmmus are seemingly unaffected because the $(TOOLS), which each =
have
> a dependency on $(trace-obj-y), are built first for the build-all targe=
t.
>=20
> Add a dependency on $(trace-obj-y) for %-user, as done for the qemu-* t=
ools.
>=20
> Let's be paranoid and do the same for %-softmmu while at it, just in ca=
se
> someone messes with $(TOOLS) or calls the Makefile target directly.
>=20
> Signed-off-by: Andreas F=E4rber <andreas.faerber@web.de>
> Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> Cc: Prerna Saxena <prerna@linux.vnet.ibm.com>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks for the patch!

Stefan