From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38121 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvG2D-0007KA-Oe
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 16:53:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <akong@redhat.com>) id 1OvG2C-0003DY-Hg
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 16:53:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40986)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <akong@redhat.com>) id 1OvG2C-0003DE-9q
	for qemu-devel@nongnu.org; Mon, 13 Sep 2010 16:53:52 -0400
Date: Tue, 14 Sep 2010 04:53:39 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20100913205338.GA2607@z>
References: <1284155276-14959-1-git-send-email-hpa@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1284155276-14959-1-git-send-email-hpa@linux.intel.com>
Subject: [Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device
	model
Reply-To: Amos Kong <akong@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>

On Fri, Sep 10, 2010 at 02:47:56PM -0700, H. Peter Anvin wrote:
> I discovered that none of the audio device models supported by current
> Qemu/KVM appear to be supported out of the box on Win7 64 bit (AC97
> works fine on 32 bit).  The most logical ways to fix that would be to
> add a long-term supportable audio device model.  Intel HD Audio and
> USB Audio seemed like the most reasonable options, but I opted for USB
> Audio for a few reasons:

...
> diff --git a/configure b/configure
> index 8228c1c..4fcb829 100755
> --- a/configure
> +++ b/configure
> @@ -71,8 +71,8 @@ sparc_cpu=""
>  cross_prefix=""
>  cc="gcc"
>  audio_drv_list=""
> -audio_card_list="ac97 es1370 sb16"
> -audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus"
> +audio_card_list="ac97 es1370 sb16 usb-audio"
> +audio_possible_cards="ac97 es1370 sb16 cs4231a adlib gus usb-audio"
>  block_drv_whitelist=""
>  host_cc="gcc"
>  ar="ar"
> @@ -2414,7 +2414,7 @@ if test "$vde" = "yes" ; then
>  fi
>  for card in $audio_card_list; do
>      def=CONFIG_`echo $card | tr '[:lower:]' '[:upper:]'`
> -    echo "$def=y" >> $config_host_mak
> +    echo ${def//-/_}=y >> $config_host_mak
>  done
>  echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak
>  for drv in $audio_drv_list; do

# patch -p1 < /tmp/usb-audio.patch
# ./configure
...
...
preadv support    yes
fdatasync         yes
uuid support      no
vhost-net support no
Trace backend     nop
Trace output file trace-<pid>
./configure: 2276: Bad substitution


> diff --git a/create_config b/create_config
> index 0098e68..1caa25b 100755
> --- a/create_config
> +++ b/create_config
> @@ -25,7 +25,7 @@ case $line in
>   CONFIG_AUDIO_DRIVERS=*)
>      drivers=${line#*=}
>      echo "#define CONFIG_AUDIO_DRIVERS \\"
> -    for drv in $drivers; do
> +    for drv in ${drivers//-/_}; do
>        echo "    &${drv}_audio_driver,\\"
>      done
>      echo ""
> @@ -39,10 +39,12 @@ case $line in
>      ;;
>   CONFIG_*=y) # configuration
>      name=${line%=*}
> +    name=${name//-/_}
>      echo "#define $name 1"
>      ;;
>   CONFIG_*=*) # configuration
>      name=${line%=*}
> +    name=${name//-/_}
>      value=${line#*=}
>      echo "#define $name $value"
>      ;;

...