qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Michal Novotny <minovotn@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] serial: Update parameters after load
Date: Wed, 15 Sep 2010 15:53:56 +0200	[thread overview]
Message-ID: <20100915135356.GA29442@edde.se.axis.com> (raw)
In-Reply-To: <4C8E2B60.1010909@redhat.com>

On Mon, Sep 13, 2010 at 03:47:12PM +0200, Michal Novotny wrote:
> Hi,
> 
> this is the patch to update serial port parameters after guest is
> already loaded.

Hi

This patch didn't apply:

% git am -s ~/.maildir/minovotn/
Applying: serial: Update parameters after load
error: patch failed: hw/serial.c:674
error: hw/serial.c: patch does not apply
Patch failed at 0001 serial: Update parameters after load
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort"

> 
> Signed-off-by: Michal Novotny<minovotn@redhat.com>
                             ^^^^
                          missing space


I manually fixed both errors and applied it.

Cheers,
Edgar


> ---
>   hw/serial.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/serial.c b/hw/serial.c
> index 49431b2..bf74876 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -674,6 +674,7 @@ static int serial_post_load(void *opaque, int version_id)
>       }
>       /* Initialize fcr via setter to perform essential side-effects */
>       serial_ioport_write(s, 0x02, s->fcr_vmstate);
> +    serial_update_parameters(s);
>       return 0;
>   }
> 
> -- 
> 1.7.2.3

  reply	other threads:[~2010-09-15 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 13:47 [Qemu-devel] [PATCH] serial: Update parameters after load Michal Novotny
2010-09-15 13:53 ` Edgar E. Iglesias [this message]
2010-09-15 14:39   ` Michal Novotny
2010-09-15 14:45     ` Edgar E. Iglesias
2010-09-15 15:04       ` Michal Novotny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100915135356.GA29442@edde.se.axis.com \
    --to=edgar.iglesias@gmail.com \
    --cc=minovotn@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).