From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48908 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvtTz-0002Fu-US
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:01:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <edgar.iglesias@gmail.com>) id 1OvtTi-0001iB-Ph
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:01:11 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:39910)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <edgar.iglesias@gmail.com>) id 1OvtTi-0001i3-L9
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:00:54 -0400
Received: by bwz4 with SMTP id 4so674010bwz.4
	for <qemu-devel@nongnu.org>; Wed, 15 Sep 2010 08:00:53 -0700 (PDT)
Date: Wed, 15 Sep 2010 16:45:50 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] serial: Update parameters after load
Message-ID: <20100915144550.GC29442@edde.se.axis.com>
References: <4C8E2B60.1010909@redhat.com>
	<20100915135356.GA29442@edde.se.axis.com>
	<4C90DA98.2010807@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C90DA98.2010807@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michal Novotny <minovotn@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Wed, Sep 15, 2010 at 04:39:20PM +0200, Michal Novotny wrote:
> On 09/15/2010 03:53 PM, Edgar E. Iglesias wrote:
> > On Mon, Sep 13, 2010 at 03:47:12PM +0200, Michal Novotny wrote:
> >    
> >> Hi,
> >>
> >> this is the patch to update serial port parameters after guest is
> >> already loaded.
> >>      
> > Hi
> >
> > This patch didn't apply:
> >
> > % git am -s ~/.maildir/minovotn/
> > Applying: serial: Update parameters after load
> > error: patch failed: hw/serial.c:674
> > error: hw/serial.c: patch does not apply
> > Patch failed at 0001 serial: Update parameters after load
> > When you have resolved this problem run "git am --resolved".
> > If you would prefer to skip this patch, instead run "git am --skip".
> > To restore the original branch and stop patching run "git am --abort"
> >
> >    
> >> Signed-off-by: Michal Novotny<minovotn@redhat.com>
> >>      
> >                               ^^^^
> >                            missing space
> >    
> 
> Hi, thanks. Nevetheless should there be a space between name and e-mail 
> address? I didn't know what's right so if there should be a space please 
> tell me to take care of it next time.

Hi Michal,

If you setup your git environment with your name and email, you can
pass the -s flag to commit or set the format.signoff config option
and git will generate the SoB line for you.

Cheers