* [Qemu-devel] [PATCH] fix virtio-blk failure after reboot
@ 2010-09-15 16:31 Gleb Natapov
2010-09-15 21:05 ` [Qemu-devel] " Michael S. Tsirkin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gleb Natapov @ 2010-09-15 16:31 UTC (permalink / raw)
To: seabios; +Cc: qemu-devel
vring_virtqueue should be zeroed otherwise old values will be reused
after reboot.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/src/virtio-blk.c b/src/virtio-blk.c
index 34d7863..7a25826 100644
--- a/src/virtio-blk.c
+++ b/src/virtio-blk.c
@@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf)
goto fail;
}
memset(vdrive_g, 0, sizeof(*vdrive_g));
+ memset(vq, 0, sizeof(*vq));
vdrive_g->drive.type = DTYPE_VIRTIO;
vdrive_g->drive.cntl_id = bdf;
vdrive_g->vq = vq;
--
Gleb.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [PATCH] fix virtio-blk failure after reboot
2010-09-15 16:31 [Qemu-devel] [PATCH] fix virtio-blk failure after reboot Gleb Natapov
@ 2010-09-15 21:05 ` Michael S. Tsirkin
2010-09-25 15:44 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
2010-11-08 23:59 ` Kevin O'Connor
2 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2010-09-15 21:05 UTC (permalink / raw)
To: Gleb Natapov; +Cc: seabios, qemu-devel
On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
> vring_virtqueue should be zeroed otherwise old values will be reused
> after reboot.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
Nice one.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> diff --git a/src/virtio-blk.c b/src/virtio-blk.c
> index 34d7863..7a25826 100644
> --- a/src/virtio-blk.c
> +++ b/src/virtio-blk.c
> @@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf)
> goto fail;
> }
> memset(vdrive_g, 0, sizeof(*vdrive_g));
> + memset(vq, 0, sizeof(*vq));
> vdrive_g->drive.type = DTYPE_VIRTIO;
> vdrive_g->drive.cntl_id = bdf;
> vdrive_g->vq = vq;
> --
> Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot
2010-09-15 16:31 [Qemu-devel] [PATCH] fix virtio-blk failure after reboot Gleb Natapov
2010-09-15 21:05 ` [Qemu-devel] " Michael S. Tsirkin
@ 2010-09-25 15:44 ` Kevin O'Connor
2010-11-08 23:59 ` Kevin O'Connor
2 siblings, 0 replies; 6+ messages in thread
From: Kevin O'Connor @ 2010-09-25 15:44 UTC (permalink / raw)
To: Gleb Natapov; +Cc: seabios, qemu-devel
On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
> vring_virtqueue should be zeroed otherwise old values will be reused
> after reboot.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
Applied. Thanks.
-Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot
2010-09-15 16:31 [Qemu-devel] [PATCH] fix virtio-blk failure after reboot Gleb Natapov
2010-09-15 21:05 ` [Qemu-devel] " Michael S. Tsirkin
2010-09-25 15:44 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
@ 2010-11-08 23:59 ` Kevin O'Connor
2010-11-09 6:46 ` Gleb Natapov
2 siblings, 1 reply; 6+ messages in thread
From: Kevin O'Connor @ 2010-11-08 23:59 UTC (permalink / raw)
To: Gleb Natapov, Anthony Liguori, Avi Kivity; +Cc: seabios, qemu-devel
On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
> vring_virtqueue should be zeroed otherwise old values will be reused
> after reboot.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/src/virtio-blk.c b/src/virtio-blk.c
> index 34d7863..7a25826 100644
> --- a/src/virtio-blk.c
> +++ b/src/virtio-blk.c
> @@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf)
> goto fail;
> }
> memset(vdrive_g, 0, sizeof(*vdrive_g));
> + memset(vq, 0, sizeof(*vq));
> vdrive_g->drive.type = DTYPE_VIRTIO;
> vdrive_g->drive.cntl_id = bdf;
> vdrive_g->vq = vq;
This didn't make it into SeaBIOS v0.6.1. Should we add this to the
stable branch as v0.6.1.2? Any other bugfixes that need to go in to
the stable branch (maybe Isaku's pci overflow patches)?
-Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot
2010-11-08 23:59 ` Kevin O'Connor
@ 2010-11-09 6:46 ` Gleb Natapov
2010-11-13 15:01 ` Kevin O'Connor
0 siblings, 1 reply; 6+ messages in thread
From: Gleb Natapov @ 2010-11-09 6:46 UTC (permalink / raw)
To: Kevin O'Connor; +Cc: seabios, Avi Kivity, qemu-devel
On Mon, Nov 08, 2010 at 06:59:37PM -0500, Kevin O'Connor wrote:
> On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
> > vring_virtqueue should be zeroed otherwise old values will be reused
> > after reboot.
> >
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > diff --git a/src/virtio-blk.c b/src/virtio-blk.c
> > index 34d7863..7a25826 100644
> > --- a/src/virtio-blk.c
> > +++ b/src/virtio-blk.c
> > @@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf)
> > goto fail;
> > }
> > memset(vdrive_g, 0, sizeof(*vdrive_g));
> > + memset(vq, 0, sizeof(*vq));
> > vdrive_g->drive.type = DTYPE_VIRTIO;
> > vdrive_g->drive.cntl_id = bdf;
> > vdrive_g->vq = vq;
>
> This didn't make it into SeaBIOS v0.6.1. Should we add this to the
> stable branch as v0.6.1.2? Any other bugfixes that need to go in to
> the stable branch (maybe Isaku's pci overflow patches)?
>
Yes. Please add it to stable branch.
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] Re: [SeaBIOS] [PATCH] fix virtio-blk failure after reboot
2010-11-09 6:46 ` Gleb Natapov
@ 2010-11-13 15:01 ` Kevin O'Connor
0 siblings, 0 replies; 6+ messages in thread
From: Kevin O'Connor @ 2010-11-13 15:01 UTC (permalink / raw)
To: Gleb Natapov; +Cc: seabios, Avi Kivity, qemu-devel
On Tue, Nov 09, 2010 at 08:46:43AM +0200, Gleb Natapov wrote:
> On Mon, Nov 08, 2010 at 06:59:37PM -0500, Kevin O'Connor wrote:
> > On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
> > > vring_virtqueue should be zeroed otherwise old values will be reused
> > > after reboot.
> > >
> > > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > > diff --git a/src/virtio-blk.c b/src/virtio-blk.c
> > > index 34d7863..7a25826 100644
> > > --- a/src/virtio-blk.c
> > > +++ b/src/virtio-blk.c
> > > @@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf)
> > > goto fail;
> > > }
> > > memset(vdrive_g, 0, sizeof(*vdrive_g));
> > > + memset(vq, 0, sizeof(*vq));
> > > vdrive_g->drive.type = DTYPE_VIRTIO;
> > > vdrive_g->drive.cntl_id = bdf;
> > > vdrive_g->vq = vq;
> >
> > This didn't make it into SeaBIOS v0.6.1. Should we add this to the
> > stable branch as v0.6.1.2? Any other bugfixes that need to go in to
> > the stable branch (maybe Isaku's pci overflow patches)?
> >
> Yes. Please add it to stable branch.
I added it and tagged it as v0.6.1.2.
-Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-11-13 15:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-15 16:31 [Qemu-devel] [PATCH] fix virtio-blk failure after reboot Gleb Natapov
2010-09-15 21:05 ` [Qemu-devel] " Michael S. Tsirkin
2010-09-25 15:44 ` [Qemu-devel] Re: [SeaBIOS] " Kevin O'Connor
2010-11-08 23:59 ` Kevin O'Connor
2010-11-09 6:46 ` Gleb Natapov
2010-11-13 15:01 ` Kevin O'Connor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).