From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54150 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvzFv-0005jC-RY
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 17:11:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OvzFu-0003Sj-TW
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 17:11:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54407)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OvzFu-0003SZ-Fq
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 17:11:02 -0400
Date: Wed, 15 Sep 2010 23:05:03 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100915210503.GC5526@redhat.com>
References: <20100915163144.GM3008@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100915163144.GM3008@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] fix virtio-blk failure after reboot
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

On Wed, Sep 15, 2010 at 06:31:44PM +0200, Gleb Natapov wrote:
> vring_virtqueue should be zeroed otherwise old values will be reused
> after reboot.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>

Nice one.

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> diff --git a/src/virtio-blk.c b/src/virtio-blk.c
> index 34d7863..7a25826 100644
> --- a/src/virtio-blk.c
> +++ b/src/virtio-blk.c
> @@ -109,6 +109,7 @@ init_virtio_blk(u16 bdf)
>          goto fail;
>      }
>      memset(vdrive_g, 0, sizeof(*vdrive_g));
> +    memset(vq, 0, sizeof(*vq));
>      vdrive_g->drive.type = DTYPE_VIRTIO;
>      vdrive_g->drive.cntl_id = bdf;
>      vdrive_g->vq = vq;
> --
> 			Gleb.