From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35297 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ozqlt-0002i6-MU
	for qemu-devel@nongnu.org; Sun, 26 Sep 2010 08:56:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OzqlU-0004gg-KS
	for qemu-devel@nongnu.org; Sun, 26 Sep 2010 08:55:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52166)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1OzqlU-0004ga-Ai
	for qemu-devel@nongnu.org; Sun, 26 Sep 2010 08:55:36 -0400
Date: Sun, 26 Sep 2010 14:49:40 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100926124940.GG19655@redhat.com>
References: <cover.1284528424.git.yamahata@valinux.co.jp>
	<bc0b875bfb85b10d95a268cf6630963c23a779df.1284528424.git.yamahata@valinux.co.jp>
	<20100922112559.GC16423@redhat.com>
	<20100924053809.GF4701@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100924053809.GF4701@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH v3 08/13] pcie root port: implement pcie
	root port.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: skandasa@cisco.com, etmartin@cisco.com, qemu-devel@nongnu.org, wexu2@cisco.com

On Fri, Sep 24, 2010 at 02:38:09PM +0900, Isaku Yamahata wrote:
> On Wed, Sep 22, 2010 at 01:25:59PM +0200, Michael S. Tsirkin wrote:
> 
> > > +PCIESlot *pcie_root_init(PCIBus *bus, int devfn, bool multifunction,
> > > +                         const char *bus_name, pci_map_irq_fn map_irq,
> > > +                         uint8_t port, uint8_t chassis, uint16_t slot);
> > > +
> > 
> > I am a bit unhappy about all these _init functions.
> > Can devices be created with qdev? If they were
> > it would be possible to configure the system completely
> > from qemu command line.
> 
> That's very reasonable question.
> Once machine configuration file is supported, those initialization
> functions will go away.
> I.e. when the initialization code like pc_init1() in pc_piix.c disappears,
> those functions will also go away.
> 
> Until that, those initialization glues will stay like pci_create family
> or other many initialization glues unfortunately.
> This is the result of qdev missing a feature, not the cause.
> It would be a long-term issue to add machine configuration file support.

Yes, but will it be better to do everything from qdev_init?

> -- 
> yamahata