From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37340 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P08eF-000738-QE for qemu-devel@nongnu.org; Mon, 27 Sep 2010 04:01:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P08W7-0001Fn-LD for qemu-devel@nongnu.org; Mon, 27 Sep 2010 03:52:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27497) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P08W7-0001FQ-Ed for qemu-devel@nongnu.org; Mon, 27 Sep 2010 03:52:55 -0400 From: Jason Wang Date: Mon, 27 Sep 2010 15:52:44 +0800 Message-ID: <20100927075244.8835.530.stgit@dhcp-91-7.nay.redhat.com.englab.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] monitor: properly handle invalid fd/vhostfd from command line List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, anthony@codemonkey.ws, mst@redhat.com monitor_get_fd() may also be used to parse fd or vhostfd from command line, so we need to check whether the pointer of mon is NULL to avoid segmentation fault when user pass invalid name of fd or vhostfd. Signed-off-by: Jason Wang --- monitor.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index e602480..5bb4ff0 100644 --- a/monitor.c +++ b/monitor.c @@ -2345,6 +2345,10 @@ int monitor_get_fd(Monitor *mon, const char *fdname) { mon_fd_t *monfd; + if (mon == NULL) { + return -1; + } + QLIST_FOREACH(monfd, &mon->fds, next) { int fd;