From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42723 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0bEN-0000ge-34
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 10:32:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1P0bEL-000167-VJ
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 10:32:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54883)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1P0bEL-00015z-OC
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 10:32:29 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8SEWSQ0017423
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 28 Sep 2010 10:32:29 -0400
Date: Tue, 28 Sep 2010 11:32:25 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an
	'o' argument rather than a float.
Message-ID: <20100928113225.3808d326@doriath>
In-Reply-To: <m3d3ryji48.fsf@blackfin.pond.sub.org>
References: <1284648749-18479-1-git-send-email-Jes.Sorensen@redhat.com>
	<1284648749-18479-5-git-send-email-Jes.Sorensen@redhat.com>
	<m3d3ryji48.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com

On Tue, 28 Sep 2010 12:08:07 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Jes.Sorensen@redhat.com writes:
> 
> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >
> > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> > ---
> >  migration.c     |    4 ++--
> >  qemu-monitor.hx |    2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/migration.c b/migration.c
> > index 468d517..9ee8b17 100644
> > --- a/migration.c
> > +++ b/migration.c
> > @@ -132,10 +132,10 @@ int do_migrate_cancel(Monitor *mon, const QDict *qdict, QObject **ret_data)
> >  
> >  int do_migrate_set_speed(Monitor *mon, const QDict *qdict, QObject **ret_data)
> >  {
> > -    double d;
> > +    int64_t d;
> >      FdMigrationState *s;
> >  
> > -    d = qdict_get_double(qdict, "value");
> > +    d = qdict_get_int(qdict, "value");
> >      d = MAX(0, MIN(UINT32_MAX, d));
> >      max_throttle = d;
> 
> This isn't backwards bug-compatible.
> 
> Before, a client could send any number.  Any fractional part was
> ignored.
> 
> Now, the number must be an integer.  Other numbers are rejected.
> 
> I don't care myself, but others have argued most forcefully for keeping
> QMP fully backward compatible from 0.13 on, so they might object.

Can't we have a small fix for 0.13? We still have time I guess.

> 
> > diff --git a/qemu-monitor.hx b/qemu-monitor.hx
> > index 49bcd8d..7f58fb2 100644
> > --- a/qemu-monitor.hx
> > +++ b/qemu-monitor.hx
> > @@ -1093,7 +1093,7 @@ EQMP
> >  
> >      {
> >          .name       = "migrate_set_speed",
> > -        .args_type  = "value:f",
> > +        .args_type  = "value:o",
> >          .params     = "value",
> >          .help       = "set maximum speed (in bytes) for migrations",
> >          .user_print = monitor_user_noop,
> 
> Doesn't this change the interpretation of "42" from 42 to (42 << 20)?
>