Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation

[Amit Shah <amit.shah@redhat.com>]

On (Tue) Sep 28 2010 [15:52:02], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > Add a 'description' along with each qdev property to document the input
> > each qdev property takes.
> [...]
> > diff --git a/hw/qdev.c b/hw/qdev.c
> > index 35858cb..b415025 100644
> > --- a/hw/qdev.c
> > +++ b/hw/qdev.c
> > @@ -188,7 +188,8 @@ int qdev_device_help(QemuOpts *opts)
> >          if (!prop->info->parse) {
> >              continue;           /* no way to set it, don't show */
> >          }
> > -        error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> > +        error_printf("%s.%s=%s, %s\n", info->name, prop->name,
> > +                     prop->info->name, prop->desc ?: "");
> >      }
> >      return 1;
> >  }
> 
> This is the only patch hunk that isn't about defining or initializing
> the new member desc, isn't it?

Right; the other hunks just add the new desc field for all the callers.

		Amit