From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51924 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0alH-00020c-I0
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 10:02:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1P0alD-0004K7-BR
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 10:02:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33699)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1P0alD-0004K1-4b
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 10:02:23 -0400
Date: Tue, 28 Sep 2010 19:32:23 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev
	properties for documentation
Message-ID: <20100928140223.GJ2636@amit-laptop.redhat.com>
References: <cover.1284553514.git.amit.shah@redhat.com>
	<cover.1284553514.git.amit.shah@redhat.com>
	<b8f2ad691ff783d815c38918f223646b6518b522.1284553514.git.amit.shah@redhat.com>
	<m3eiceascd.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3eiceascd.fsf@blackfin.pond.sub.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>

On (Tue) Sep 28 2010 [15:52:02], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > Add a 'description' along with each qdev property to document the input
> > each qdev property takes.
> [...]
> > diff --git a/hw/qdev.c b/hw/qdev.c
> > index 35858cb..b415025 100644
> > --- a/hw/qdev.c
> > +++ b/hw/qdev.c
> > @@ -188,7 +188,8 @@ int qdev_device_help(QemuOpts *opts)
> >          if (!prop->info->parse) {
> >              continue;           /* no way to set it, don't show */
> >          }
> > -        error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> > +        error_printf("%s.%s=%s, %s\n", info->name, prop->name,
> > +                     prop->info->name, prop->desc ?: "");
> >      }
> >      return 1;
> >  }
> 
> This is the only patch hunk that isn't about defining or initializing
> the new member desc, isn't it?

Right; the other hunks just add the new desc field for all the callers.

		Amit