From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35089 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P2keI-0003cp-Ur
	for qemu-devel@nongnu.org; Mon, 04 Oct 2010 09:00:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P2keH-0003GB-23
	for qemu-devel@nongnu.org; Mon, 04 Oct 2010 09:00:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21260)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P2keG-0003Fz-SI
	for qemu-devel@nongnu.org; Mon, 04 Oct 2010 09:00:09 -0400
Date: Mon, 4 Oct 2010 14:53:52 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] eepro100: Add support for multiple
	individual addresses (multiple IA)
Message-ID: <20101004125351.GA29083@redhat.com>
References: <4CA38D83.9040106@mail.berlios.de>
	<1285790395-25460-1-git-send-email-weil@mail.berlios.de>
	<20100929203010.GA7472@laped.lan>
	<20101003095653.GA16313@redhat.com>
	<4CA856DB.2070805@mail.berlios.de>
	<20101003111635.GC17133@redhat.com>
	<4CA86D61.3080200@mail.berlios.de>
	<20101003132051.GC19184@redhat.com>
	<4CA9CF3B.9030400@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CA9CF3B.9030400@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Dunc <dunc@lemonia.org>, QEMU Developers <qemu-devel@nongnu.org>

On Mon, Oct 04, 2010 at 02:57:31PM +0200, Stefan Weil wrote:
> Am 03.10.2010 15:20, schrieb Michael S. Tsirkin:
> >On Sun, Oct 03, 2010 at 01:47:45PM +0200, Stefan Weil wrote:
> >>>>It might be applied to the stable branches, too.
> >>>>
> >>>>Thanks,
> >>>>Stefan
> >>>
> >>>To me, this doesn't look like a stable branch material: this adds is a
> >>>new feature, not a bugfix. Which guests benefit and how does
> >>>one use the routing emulation?
> >>
> >>
> >>The first mail in this thread should answer your question.
> >>
> >>It depends on your point of view whether better emulation
> >>adds a new feature or fixes a bug:
> >
> >When in doubt, excercise caution. But in the end, I think it's your call:
> >do you want this in 0.13 stable, too?
> 
> 
> Yes. The patch is strictly limited to eepro100.c, and even there
> its risk is limited to a highly specialized functionality.
> 
> On the other side we get a stable version 0.13 with increased
> usability for a lot of people who use qemu with eepro100 to
> emulate their routers.
> 
> Therefore it would be good to have this patch in 0.13 as well.
> 
> Regards,
> Stefan

OK then.
I've applied the patch in my tree, and I have no objections
against it going into stable.

-- 
MST