qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] configure: include stddef.h for NULL
Date: Tue, 5 Oct 2010 11:30:29 -0500	[thread overview]
Message-ID: <20101005113029.06a944d5@udp111988uds.am.freescale.net> (raw)
In-Reply-To: <m3lj6df4mg.fsf@blackfin.pond.sub.org>

On Tue, 5 Oct 2010 10:03:35 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Scott Wood <scottwood@freescale.com> writes:
> 
> > This fixes an observed failure to detect madvise() on Linux.
> >
> > To avoid similar issues, all other tests that use NULL but don't already
> > have stddef.h are also fixed.
> 
> Appreciated, but several instances don't need fixing, because existing
> includes already provide NULL.
> 
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
> > ---
> >  configure |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/configure b/configure
> > index e0d34fd..9c4f1db 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1276,6 +1276,7 @@ if test "$vnc_sasl" != "no" ; then
> >    cat > $TMPC <<EOF
> >  #include <sasl/sasl.h>
> >  #include <stdio.h>
> > +#include <stddef.h>
> 
> stdio.h provides NULL.

Hmm, I had looked up a reference to see if stdio.h is defined to
supply this, and didn't see it.  Today I see it. :-P

I'll respin the patch.

-Scott

      reply	other threads:[~2010-10-05 16:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 21:17 [Qemu-devel] [PATCH] configure: include stddef.h for NULL Scott Wood
2010-10-05  8:03 ` Markus Armbruster
2010-10-05 16:30   ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101005113029.06a944d5@udp111988uds.am.freescale.net \
    --to=scottwood@freescale.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).