From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60723 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P4h2G-0007Gx-Gt
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 17:32:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ingo_weinhold@gmx.de>) id 1P4gus-0003Q2-B8
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 17:25:19 -0400
Received: from mailout-de.gmx.net ([213.165.64.23]:59760 helo=mail.gmx.net)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <ingo_weinhold@gmx.de>) id 1P4gur-0003Pt-VD
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 17:25:18 -0400
Date: Sat, 09 Oct 2010 23:18:04 +0200
From: Ingo Weinhold <ingo_weinhold@gmx.de>
In-Reply-To: <1286654117-16193-1-git-send-email-andreas.faerber@web.de>
Message-Id: <20101009231804.356.1@knochen-vm.localdomain>
Mime-Version: 1.0
References: <1286654117-16193-1-git-send-email-andreas.faerber@web.de>
Content-Type: text/plain;
 charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Subject: [Qemu-devel] Re: [HaikuPorts-devs] [PATCH] trace: Adapt trace file
 name for Haiku
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: HaikuPorts developers discussion list <haikuports-devs@ports.haiku-files.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, =?utf-8?q?Andreas_F=C3=A4rber?= <andreas.faerber@web.de>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org


On 2010-10-09 at 21:55:17 =5B+0200=5D, Andreas F=C3=A4rber <andreas.faerber=
=40web.de> wrote:
> Resolves the following warning:
>=20
>   CC    simpletrace.o
> /Data/QEMU/qemu/simpletrace.c: In function =27st_set_trace_file=27:
> /Data/QEMU/qemu/simpletrace.c:77: warning: format =27%u=27 expects type=20
> =27unsigned int=27, but argument 3 has type =27pid_t=27
>=20
> Cc: Stefan Hajnoczi <stefanha=40linux.vnet.ibm.com>
> Cc: Blue Swirl <blauwirbel=40gmail.com>
> Signed-off-by: Andreas F=C3=A4rber <andreas.faerber=40web.de>
> ---
>  configure =7C    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>=20
> diff --git a/configure b/configure
> index d303061..3e694a2 100755
> --- a/configure
> +++ b/configure
> =40=40 -2609,7 +2609,11 =40=40 if test =22=24trace_backend=22 =3D =22simp=
le=22; then
>  fi
>  =23 Set the appropriate trace file.
>  if test =22=24trace_backend=22 =3D =22simple=22; then
> -  trace_file=3D=22=5C=22=24trace_file-%u=5C=22=22
> +  if test =22=24haiku=22 =3D =22yes=22; then
> +    trace_file=3D=22=5C=22=24trace_file-%lu=5C=22=22
> +  else
> +    trace_file=3D=22=5C=22=24trace_file-%u=5C=22=22
> +  fi
>  fi
>  echo =22CONFIG_TRACE_FILE=3D=24trace_file=22 >> =24config_host_mak
>=20=20
> --
> 1.7.3

Please don=27t apply. The patch doesn=27t work for 64 bit Haiku.

According to POSIX:

  =22blksize_t, pid_t, and ssize_t shall be signed integer types.=22

and

  =22... the widths of blksize_t, pid_t, size_t, ssize_t, and suseconds_t a=
re no greater=20
than the width of type long=22

So a safe and portable solution would be to use =22%ld=22 and cast the pid_=
t to long.

CU, Ingo