From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51627 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P6KlL-0007ZE-Uj
	for qemu-devel@nongnu.org; Thu, 14 Oct 2010 06:10:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P6KlK-0001Jv-Rb
	for qemu-devel@nongnu.org; Thu, 14 Oct 2010 06:10:15 -0400
Received: from mtagate6.uk.ibm.com ([194.196.100.166]:40953)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P6KlK-0001Jm-KX
	for qemu-devel@nongnu.org; Thu, 14 Oct 2010 06:10:14 -0400
Received: from d06nrmr1806.portsmouth.uk.ibm.com
	(d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193])
	by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id o9EAADNu012271
	for <qemu-devel@nongnu.org>; Thu, 14 Oct 2010 10:10:13 GMT
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o9EAA5jQ2502724
	for <qemu-devel@nongnu.org>; Thu, 14 Oct 2010 11:10:13 +0100
Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o9EAA4u6016217
	for <qemu-devel@nongnu.org>; Thu, 14 Oct 2010 11:10:04 +0100
Date: Thu, 14 Oct 2010 11:10:04 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20101014101003.GB3488@stefan-thinkpad.transitives.com>
References: <20101014112143.01363808@zephyr> <20101014113120.386e8840@zephyr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20101014113120.386e8840@zephyr>
Subject: [Qemu-devel] Re: [Tracing] [RFC PATCH 2/2] : Documentation for QMP
	interfaces
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: Mahesh <mahesh@linux.vnet.ibm.com>, Ananth Narayan <ananth@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On Thu, Oct 14, 2010 at 11:31:20AM +0530, Prerna Saxena wrote:
> [PATCH 2/2] Add documentation for QMP commands: query-trace & query-trace-events.
> 
> 
> Signed-off-by: Prerna Saxena <prerna@linux.vnet.ibm.com>
> ---
>  qmp-commands.hx |   53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 53 insertions(+), 0 deletions(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 793cf1c..9a48984 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1539,3 +1539,56 @@ Example:
> 
>  EQMP
> 
> +SQMP
> +query-trace
> +-------------
> +
> +Show contents of trace buffer.
> +
> +Returns a set of json-objects containing the following data:
> +
> +- "Event": Event ID for the trace-event(json-int)

JSON names are lowercase like the C fields they represent, please use
"event".

> +- "arg1 .. arg6": Arguments logged by the trace-event (json-int)

What about the timestamp_ns field?

> +
> +Example:
> +
> +-> { "execute": "query-trace" }
> +<- {
> +      "return":{
> +         "Event": 22,
> +         "arg6": 0,
> +         "arg5": 0,
> +         "arg4": 0,
> +         "arg3": 0,
> +         "arg2": 80,
> +         "arg1": 886
> +       }
> +   }
> +
> +EQMP
> +
> +SQMP
> +query-trace-events
> +------------------
> +
> +Show all available trace-events & their state.
> +
> +Returns a set of json-objects containing the following data:
> +
> +- "name": Name of Trace-event (json-string)
> +- "state": State of trace-event [ '0': inactive; '1':active  ] (json-int)
> +- "eventID": Event ID of Trace-event (json-int)
> +
> +Example:
> +
> +-> { "execute": "query-trace-events" }
> +<- {
> +      "return":{
> +         "name": "qemu_malloc",
> +         "state": 0,
> +         "eventID": 0
> +      }
> +   }
> +
> +EQMP
> +
> -- 
> 1.7.2.2
> 
> 
> 
> -- 
> Prerna Saxena
> 
> Linux Technology Centre,
> IBM Systems and Technology Lab,
> Bangalore, India
>