[Qemu-devel] Re: [PATCH 07/11] kvm, x86: unify sigbus handling, prep

[Marcelo Tosatti <mtosatti@redhat.com>]

On Thu, Oct 14, 2010 at 05:49:43PM +0900, Jin Dongming wrote:
> There are 2 similar functions to handle SIGBUS:
>   sigbus_handler(int n, struct qemu_signalfd_siginfo *siginfo,
>                  void *ctx)
>   kvm_on_sigbus(CPUState *env, siginfo_t *siginfo)
> 
> The former is used when main thread receives SIGBUS via signalfd,
> while latter is used when vcpu thread receives SIGBUS.
> These 2 take different siginfo, but in both case required parameters
> are common, the code and the addr in the info.
> 
> Restruct functions to take the code and the addr explicitly.
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> Tested-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
> ---
>  qemu-kvm.c |   41 ++++++++++++++++++++---------------------
>  1 files changed, 20 insertions(+), 21 deletions(-)

Don't see the benefit, separate functions are cleaner.