From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43963 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6Ylh-0000Hg-Ht for qemu-devel@nongnu.org; Thu, 14 Oct 2010 21:07:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6Yle-0002jU-JA for qemu-devel@nongnu.org; Thu, 14 Oct 2010 21:07:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6Yle-0002jG-BZ for qemu-devel@nongnu.org; Thu, 14 Oct 2010 21:07:30 -0400 Date: Thu, 14 Oct 2010 22:06:49 -0300 From: Marcelo Tosatti Message-ID: <20101015010649.GB32272@amt.cnet> References: <4CB6C580.1090804@np.css.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CB6C580.1090804@np.css.fujitsu.com> Subject: [Qemu-devel] Re: [PATCH 11/11] kvm, x86: broadcast mce depending on the cpu version List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jin Dongming Cc: Hidetoshi Seto , KVM list , Dean Nelson , "qemu-devel@nongnu.org" , Avi Kivity , Huang Ying On Thu, Oct 14, 2010 at 05:55:28PM +0900, Jin Dongming wrote: > There is no reason why SRAO event received by the main thread > is the only one that being broadcasted. > > According to the x86 ASDM vol.3A 15.10.4.1, > MCE signal is broadcast on processor version 06H_EH or later. > > This change is required to handle SRAR in the guest. > > Signed-off-by: Hidetoshi Seto > Tested-by: Jin Dongming > --- > qemu-kvm.c | 63 +++++++++++++++++++++++++++++------------------------------ > 1 files changed, 31 insertions(+), 32 deletions(-) Why is this necessary? _AO SIGBUS should be sent to all vcpu threads and main thread. Please separate bug fixes from cleanups. Very nice, thanks.