From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: hch@lst.de, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH][qemu-iotests] Improve test for qemu-img convert with backing file
Date: Fri, 15 Oct 2010 16:57:25 +0200 [thread overview]
Message-ID: <20101015145725.GA16016@lst.de> (raw)
In-Reply-To: <1287061278-17908-1-git-send-email-kwolf@redhat.com>
On Thu, Oct 14, 2010 at 03:01:18PM +0200, Kevin Wolf wrote:
> Additionally to testing the qemu-img convert -B option, also test
> -o backing_file.
>
> Also, the old test acidentlly used a pattern of zeros for most of the writes,
> so that the allocation test didn't really work out. This is fixed by using an
> explicit pattern.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> 019 | 59 ++++++++++++++++++++++++++++++++++++-----------------------
> 1 files changed, 36 insertions(+), 23 deletions(-)
It's missing the update to the golden output an now fails.
Btw, did you change the qemu-img check to tell people that leaked
clusters are harmless? That message causes 026 to fail for me with a
recent qemu-img.
next prev parent reply other threads:[~2010-10-15 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 13:01 [Qemu-devel] [PATCH][qemu-iotests] Improve test for qemu-img convert with backing file Kevin Wolf
2010-10-15 14:57 ` Christoph Hellwig [this message]
2010-10-15 15:56 ` [Qemu-devel] " Kevin Wolf
2010-10-15 16:06 ` Christoph Hellwig
2010-10-15 16:11 ` [Qemu-devel] [PATCH] qemu-iotests: Update expected results after qemu-img changes Kevin Wolf
2010-10-15 21:12 ` [Qemu-devel] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015145725.GA16016@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).