From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59817 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6lix-0002AK-1w for qemu-devel@nongnu.org; Fri, 15 Oct 2010 10:57:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6liv-0004Xw-Rb for qemu-devel@nongnu.org; Fri, 15 Oct 2010 10:57:34 -0400 Received: from verein.lst.de ([213.95.11.210]:49292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6liv-0004WX-JY for qemu-devel@nongnu.org; Fri, 15 Oct 2010 10:57:33 -0400 Date: Fri, 15 Oct 2010 16:57:25 +0200 From: Christoph Hellwig Message-ID: <20101015145725.GA16016@lst.de> References: <1287061278-17908-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1287061278-17908-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] Re: [PATCH][qemu-iotests] Improve test for qemu-img convert with backing file List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: hch@lst.de, qemu-devel@nongnu.org On Thu, Oct 14, 2010 at 03:01:18PM +0200, Kevin Wolf wrote: > Additionally to testing the qemu-img convert -B option, also test > -o backing_file. > > Also, the old test acidentlly used a pattern of zeros for most of the writes, > so that the allocation test didn't really work out. This is fixed by using an > explicit pattern. > > Signed-off-by: Kevin Wolf > --- > 019 | 59 ++++++++++++++++++++++++++++++++++++----------------------- > 1 files changed, 36 insertions(+), 23 deletions(-) It's missing the update to the golden output an now fails. Btw, did you change the qemu-img check to tell people that leaked clusters are harmless? That message causes 026 to fail for me with a recent qemu-img.