From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51485 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P6rYW-0007aj-3B for qemu-devel@nongnu.org; Fri, 15 Oct 2010 17:11:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P6rYV-0002n3-A4 for qemu-devel@nongnu.org; Fri, 15 Oct 2010 17:11:11 -0400 Received: from verein.lst.de ([213.95.11.210]:43044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P6rYV-0002mt-1J for qemu-devel@nongnu.org; Fri, 15 Oct 2010 17:11:11 -0400 Date: Fri, 15 Oct 2010 23:11:09 +0200 From: Christoph Hellwig Message-ID: <20101015211109.GA30107@lst.de> References: <1287158739-14635-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1287158739-14635-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] Re: [PATCH v2][qemu-iotests] Improve test for qemu-img convert with backing file List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: hch@lst.de, qemu-devel@nongnu.org On Fri, Oct 15, 2010 at 06:05:39PM +0200, Kevin Wolf wrote: > Additionally to testing the qemu-img convert -B option, also test > -o backing_file. > > Also, the old test acidentlly used a pattern of zeros for most of the writes, > so that the allocation test didn't really work out. This is fixed by using an > explicit pattern. > > Signed-off-by: Kevin Wolf > --- > v2: > - Include changes to 019.out to contain the expected output for the new script. > The test still fails on git master, but that's a real qemu-img bug. I'd rather wait adding more testing until it actually works. The alternative would be to move the test for the new option into a separate test case.