From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58840 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P7huW-000447-An
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 01:05:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P7huV-0002WO-6I
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 01:05:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39921)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P7huU-0002WI-V9
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 01:05:23 -0400
Date: Mon, 18 Oct 2010 06:59:02 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20101018045902.GA18366@redhat.com>
References: <cover.1287371107.git.yamahata@valinux.co.jp>
	<ecd72ee2e22c11a6a2df89363744b1bc5001f8d2.1287371107.git.yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ecd72ee2e22c11a6a2df89363744b1bc5001f8d2.1287371107.git.yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH v4 12/15] x3130: pcie upstream port
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: skandasa@cisco.com, adnan@khaleel.us, etmartin@cisco.com, qemu-devel@nongnu.org, wexu2@cisco.com

On Mon, Oct 18, 2010 at 12:17:53PM +0900, Isaku Yamahata wrote:
> +static void xio3130_upstream_flr(PCIDevice *d)
> +{
> +    /* TODO: not enabled until qdev reset clean up
> +       waiting for Anthony's qdev cealn up */

typo

> +#if 0
> +    /* So far, sticky bit registers or register which must be preserved
> +       over FLR aren't emulated. So just reset this device. */
> +    pci_device_reset(d);
> +#endif
> +}

-- 
MST