From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] qemu-timer: move commonly used timer code to qemu-timer-common
Date: Mon, 18 Oct 2010 11:42:34 +0100 [thread overview]
Message-ID: <20101018104233.GB2322@stefan-thinkpad.transitives.com> (raw)
In-Reply-To: <AANLkTinwpPpQQ2S=HGVSs-ZaHogNWJBHtXoq+OdRosD5@mail.gmail.com>
On Sun, Oct 17, 2010 at 01:50:33PM +0000, Blue Swirl wrote:
> Move timer init functions to a new file, qemu-timer-common.c. Make other
> critical timer functions inlined to preserve performance in
> qemu-timer.c, also move muldiv64() (used by the inline functions)
> to qemu-timer.h.
>
> Adjust block/raw-posix.c and simpletrace.c to use get_clock() directly.
> Remove a similar/duplicate definition in qemu-tool.c.
>
> Adjust hw/omap_clk.c to include qemu-timer.h because muldiv64() is used
> there.
>
> After this change, tracing can be used also for user code and
> simpletrace on Win32.
>
> Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> Makefile | 6 ++--
> Makefile.objs | 3 +-
> block/raw-posix.c | 12 ++++----
> hw/omap_clk.c | 1 +
> qemu-common.h | 2 -
> qemu-timer-common.c | 62 ++++++++++++++++++++++++++++++++++++++++++
> qemu-timer.c | 73 --------------------------------------------------
> qemu-timer.h | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++
> qemu-tool.c | 7 -----
> simpletrace.c | 10 +-----
> vl.c | 24 ----------------
> 11 files changed, 150 insertions(+), 124 deletions(-)
> create mode 100644 qemu-timer-common.c
Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2010-10-18 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 13:50 [Qemu-devel] [PATCH] qemu-timer: move commonly used timer code to qemu-timer-common Blue Swirl
2010-10-18 10:42 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018104233.GB2322@stefan-thinkpad.transitives.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).