From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57153 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P7qbX-0008Jw-Fu
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 10:22:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P7qbW-0006Eg-J6
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 10:22:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21198)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P7qbW-0006EZ-Cp
	for qemu-devel@nongnu.org; Mon, 18 Oct 2010 10:22:22 -0400
Date: Mon, 18 Oct 2010 12:21:56 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20101018122156.3410da09@doriath>
In-Reply-To: <20101018113655.09b6a48d@zephyr>
References: <20101018113655.09b6a48d@zephyr>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Tracing][RFC v3 PATCH 0/2] QMP Query interfaces
	for tracing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: Mahesh <mahesh@linux.vnet.ibm.com>, Anthony Liguori <aliguori@us.ibm.com>, Ananth Narayan <ananth@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On Mon, 18 Oct 2010 11:36:55 +0530
Prerna Saxena <prerna@linux.vnet.ibm.com> wrote:

> This patch set introduces two QMP interfaces for tracing :
> 
> * query-trace        : to list current contents of trace-buffer
> * query-trace-events : to list all available trace-events with their state.

This is in my to-review queue, but it's going to take a few days, because
I have to take a deeper look at the tracing feature to be able to review it.

Two initial questions:

 o This is labeled as an RFC, but you're versioning it. Should this be
   considered for inclusion?

 o Is this really useful w/o being able to set new traces?

> 
> Changelog :
> -----------
> Changes v2 -> v3 :
> - Change declarations of st_print_trace_to_qlist() and 
> st_print_trace_events_to_qlist() to return QList*
> 
> Changes v1 -> v2 :
> - Add 'timestamp' field for query-trace output.
> - Misc cleanups.
>