From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: adnan@khaleel.us, cam@cs.ualberta.ca, seabios@seabios.org,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [SeaBIOS] [PATCH 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions.
Date: Tue, 19 Oct 2010 10:43:17 +0900 [thread overview]
Message-ID: <20101019014317.GA21701@valinux.co.jp> (raw)
In-Reply-To: <20101018095508.GB21892@redhat.com>
On Mon, Oct 18, 2010 at 11:55:08AM +0200, Michael S. Tsirkin wrote:
> > +static u32 pci_region_alloc_align(struct pci_region *r, u32 size, u32 align)
> > +{
> > + if (r->cur_end == PCI_REGION_DISABLED) {
> > + return 0;
> > + }
>
> So is special value PCI_REGION_DISABLED or cur_end?
cur_end is in special state, and PCI_REGION_DISABLED was chosen
such that cur_end can't be PCI_REGION_DISABLED in normal case.
--
yamahata
next prev parent reply other threads:[~2010-10-19 1:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 9:34 [Qemu-devel] [PATCH 0/2] pciinit: fix overflow when bar allocation Isaku Yamahata
2010-10-18 9:34 ` [Qemu-devel] [PATCH 1/2] pci: introduce pci_region to manage pci io/memory/prefmemory regions Isaku Yamahata
2010-10-18 9:55 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-19 1:43 ` Isaku Yamahata [this message]
2010-10-18 9:34 ` [Qemu-devel] [PATCH 2/2] pciinit: use pci_region functions Isaku Yamahata
2010-10-18 9:47 ` [Qemu-devel] Re: [PATCH 0/2] pciinit: fix overflow when bar allocation Michael S. Tsirkin
2010-10-19 1:56 ` [Qemu-devel] Re: [SeaBIOS] " Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019014317.GA21701@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=adnan@khaleel.us \
--cc=cam@cs.ualberta.ca \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).