From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38354 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8B35-0001DB-9X
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 08:12:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P8B2z-00061f-63
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 08:12:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35973)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1P8B2y-00061T-Vp
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 08:12:05 -0400
Date: Tue, 19 Oct 2010 10:11:44 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] qemu aborts if i add a already registered device
	from qemu monitor ..
Message-ID: <20101019101144.47362c8c@doriath>
In-Reply-To: <20101019152737.234e2e51@skywalker>
References: <20101019152737.234e2e51@skywalker>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: pradeep <psuriset@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

On Tue, 19 Oct 2010 15:27:37 +0530
pradeep <psuriset@linux.vnet.ibm.com> wrote:

> Hi
> 
> I tried to add a device to guest from upstream qemu monitor using
> "device_add".

Are you developing a new device or does it happen with existing ones?

If it's the latter, can you describe steps to reproduce it?

> Unknowingly i try to add already registered devices from qemu
> monitor, my qemu monitor is aborted. I don't see a reason to kill
> monitor. I think abort() is a bit rough. we need a better way to handle
> it.  If a user try to add a already registered device, qemu should
> convey this to user saying that, this device already registered and an
> error message should be fine than aborting qemu.
> 
> 
>         QLIST_FOREACH(block, &ram_list.blocks, next) {
>         if (!strcmp(block->idstr, new_block->idstr)) {
>             fprintf(stderr, "RAMBlock \"%s\" already registered,
>         abort!\n",
>                     new_block->idstr);
>             abort();
>         }
> 
> 
> If i return some other value in above code, instead of abort(), I
> would  need change the code for every device, which i dont want to. 
> Is there a way to check, if device is already enrolled or not in the very beginning of "device_add"
> call.
> 
> 
> 
> Thanks
> Pradeep
>