From: "Daniel P. Berrange" <berrange@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Static tracepoint control via trace-event
Date: Tue, 19 Oct 2010 14:36:59 +0100 [thread overview]
Message-ID: <20101019133659.GH23535@redhat.com> (raw)
In-Reply-To: <4CBD9838.6040004@siemens.com>
On Tue, Oct 19, 2010 at 03:08:08PM +0200, Jan Kiszka wrote:
> Hi Stefan,
>
> just had a closer look at qemu's new tracing framework. Looks cool,
> though it leaves a bit room for improvements. ;)
>
> One quirk I stumbled over quickly was the "disable" tag in trace-events.
> It confused me first as qemu starts without any tracepoint enabled by
> default and I thought I had to hack the file. Then I read the doc and
> wondered which exiting or future backend would come without sufficiently
> fast dynamic tracepoint control. Do you have any in mind?
>
> Instead of making it a compile-time switch (except for simpletrace), I
> would vote for declaring the simpletrace usage as the only one: disable
> sets the default state of the dynamic tracepoint. That way we could use
> trace-events to define a useful set of standard, moderate-impact
> tracepoints that shall be on. Others will still be available once a
> backend is configured, but remain off until enabled during runtime.
> Anything else looks like overkill to me.
FYI with the DTrace/SystemTAP backend I posted yesterday, the 'disable'
keyword is effectively completely ignored. All tracepoints are disabled
when QEMU is running normally. Only when a end user runs a dtrace script
that references a QEMU tracepoint, is that specific tracepoint enabled.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
next prev parent reply other threads:[~2010-10-19 13:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 13:08 [Qemu-devel] Static tracepoint control via trace-event Jan Kiszka
2010-10-19 13:30 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:46 ` Jan Kiszka
2010-10-19 14:03 ` Stefan Hajnoczi
2010-10-19 14:12 ` Daniel P. Berrange
2010-10-19 14:30 ` Jan Kiszka
2010-10-19 13:36 ` Daniel P. Berrange [this message]
2010-10-19 13:52 ` [Qemu-devel] " Stefan Hajnoczi
2010-10-19 13:59 ` Jan Kiszka
2010-10-19 14:29 ` Tracing block devices (was: Re: [Qemu-devel] Static tracepoint control via trace-event) Richard W.M. Jones
2010-10-19 14:38 ` [Qemu-devel] Re: Tracing block devices Jan Kiszka
2010-10-19 14:44 ` Tracing block devices (was: Re: [Qemu-devel] Static tracepoint control via trace-event) Stefan Hajnoczi
2010-10-21 5:20 ` Christoph Hellwig
2010-10-21 7:38 ` Richard W.M. Jones
2010-10-21 9:04 ` Stefan Hajnoczi
2010-10-21 8:51 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019133659.GH23535@redhat.com \
--to=berrange@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).