From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] simpletrace: Inline runtime state check
Date: Tue, 19 Oct 2010 16:18:38 +0100 [thread overview]
Message-ID: <20101019151837.GA20899@stefan-thinkpad.transitives.com> (raw)
In-Reply-To: <4CBDA7B1.6020902@siemens.com>
On Tue, Oct 19, 2010 at 04:14:09PM +0200, Jan Kiszka wrote:
> Instead of preparing all traced args, jumping into the common trace
> function, even collecting a timestamp, do the check if a particular
> tracepoint is enabled inline. Also, mark the enabled case unlikely to
> motivate the compiler to push the trace code out of the fastpath.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> simpletrace.c | 4 ----
> tracetool | 7 +++++--
> 2 files changed, 5 insertions(+), 6 deletions(-)
Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
prev parent reply other threads:[~2010-10-19 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 14:14 [Qemu-devel] [PATCH] simpletrace: Inline runtime state check Jan Kiszka
2010-10-19 15:18 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019151837.GA20899@stefan-thinkpad.transitives.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).