From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59695 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8Dy5-0005q9-Rw
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 11:19:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P8DxZ-0000bL-7G
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 11:19:13 -0400
Received: from mtagate2.de.ibm.com ([195.212.17.162]:39050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1P8DxY-0000ay-VN
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 11:18:41 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com
	(d12nrmr1607.megacenter.de.ibm.com [9.149.167.49])
	by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id o9JFIdLq012320
	for <qemu-devel@nongnu.org>; Tue, 19 Oct 2010 15:18:39 GMT
Received: from d12av01.megacenter.de.ibm.com (d12av01.megacenter.de.ibm.com
	[9.149.165.212])
	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id o9JFId2h3866646
	for <qemu-devel@nongnu.org>; Tue, 19 Oct 2010 17:18:39 +0200
Received: from d12av01.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP
	id o9JFIdlv014991
	for <qemu-devel@nongnu.org>; Tue, 19 Oct 2010 17:18:39 +0200
Date: Tue, 19 Oct 2010 16:18:38 +0100
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20101019151837.GA20899@stefan-thinkpad.transitives.com>
References: <4CBDA7B1.6020902@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CBDA7B1.6020902@siemens.com>
Subject: [Qemu-devel] Re: [PATCH] simpletrace: Inline runtime state check
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Tue, Oct 19, 2010 at 04:14:09PM +0200, Jan Kiszka wrote:
> Instead of preparing all traced args, jumping into the common trace
> function, even collecting a timestamp, do the check if a particular
> tracepoint is enabled inline. Also, mark the enabled case unlikely to
> motivate the compiler to push the trace code out of the fastpath.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  simpletrace.c |    4 ----
>  tracetool     |    7 +++++--
>  2 files changed, 5 insertions(+), 6 deletions(-)

Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>