From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57350 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8Jms-0001Et-Bo
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:32:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P8Jmq-0005UY-L7
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:32:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30166)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1P8Jmq-0005U0-EL
	for qemu-devel@nongnu.org; Tue, 19 Oct 2010 17:32:00 -0400
Date: Tue, 19 Oct 2010 23:25:36 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id
	and device id in PCI ROM
Message-ID: <20101019212536.GA27296@redhat.com>
References: <4CBC6CDB.109@redhat.com>
	<1287424511-22021-1-git-send-email-weil@mail.berlios.de>
	<4CBC957D.3040007@codemonkey.ws> <4CBC97BE.7070902@codemonkey.ws>
	<4CBC9BFB.9090504@mail.berlios.de>
	<20101019083740.GA4465@redhat.com>
	<4CBE0A7A.5030500@mail.berlios.de> <4CBE0C0F.8030507@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4CBE0C0F.8030507@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

On Tue, Oct 19, 2010 at 04:22:23PM -0500, Anthony Liguori wrote:
> On 10/19/2010 04:15 PM, Stefan Weil wrote:
> >Am 19.10.2010 10:37, schrieb Michael S. Tsirkin:
> >>On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote:
> >>>QEMU must only make sure that patching of the supported roms
> >>>with supported devices work.
> >>
> >>I think that's what Anthony was saying too - make this depend
> >>on a qdev property and set it only in eepro100 for now.
> >>
> >
> >My new patch v3 implements something similar and does not need
> >a new qdev property:
> 
> I prefer to have an explicit property in case a user actually wants
> to use this functionality.   That said, if Michael's happy with the
> approach, I'm okay with it too.
> 
> Regards,
> 
> Anthony Liguori

I currently feel kind of the same, just to make this explicit ...
if you like, let me sleep on it.

> >Don't patch because the rom file was defined by the user:
> >
> >qemu -L pc-bios -boot n -netdev user,id=internet \
> >    -device i82801,netdev=internet,romfile=gpxe-eepro100-80861209.rom
> >
> >Patch because we work with the built-in default rom file:
> >
> >qemu -L pc-bios -boot n -netdev user,id=internet \
> >    -device i82801,netdev=internet
> >
> >This is a safe solution which respects user's rom data
> >without adding much more complexity.
> >
> >Regards,
> >Stefan
> >