From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47822 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P8VZw-0000Du-8g for qemu-devel@nongnu.org; Wed, 20 Oct 2010 06:07:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P8VZn-0003Yw-SN for qemu-devel@nongnu.org; Wed, 20 Oct 2010 06:07:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P8VZn-0003Yh-Kt for qemu-devel@nongnu.org; Wed, 20 Oct 2010 06:07:19 -0400 Date: Wed, 20 Oct 2010 12:00:46 +0200 From: "Michael S. Tsirkin" Message-ID: <20101020100046.GF10783@redhat.com> References: <6490a259eb9ff0b787998f465cdc0bec92daceb2.1287562197.git.yamahata@valinux.co.jp> <20101020084920.GB10783@redhat.com> <20101020090449.GA20484@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101020090449.GA20484@valinux.co.jp> Subject: [Qemu-devel] Re: [PATCH v6 02/12] pci/bridge: fix pci_bridge_reset() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: skandasa@cisco.com, adnan@khaleel.us, etmartin@cisco.com, qemu-devel@nongnu.org, wexu2@cisco.com On Wed, Oct 20, 2010 at 06:04:49PM +0900, Isaku Yamahata wrote: > On Wed, Oct 20, 2010 at 10:49:20AM +0200, Michael S. Tsirkin wrote: > > On Wed, Oct 20, 2010 at 05:18:51PM +0900, Isaku Yamahata wrote: > > > The default value of base/limit registers aren't specified in the spec. > > > So pci_bridge_reset() shouldn't touch them. > > > Instead, introduced two functions to reset those registers in a way > > > of typical implementation. zero base/limit registers or disable forwarding. > > > They will be used later. > > > > > > Signed-off-by: Isaku Yamahata > > > > The commit message seems to be out of date? > > Oops. Here's the update one. Only the commit log change. > Should I resend the whole series? No, I can handle that.